Skip to content

Commit 43e0ff3

Browse files
author
Artem Chernyshev
committed
[#164132100] Brought back DEB changes that were lost in force push
- run dir fixes. - change CEF cache folder.
1 parent c6d4c5b commit 43e0ff3

13 files changed

Lines changed: 91 additions & 140 deletions

File tree

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ matrix:
3030
- libglew-dev
3131
- compiler: clang
3232
os: osx
33-
osx_image: xcode9.1
33+
osx_image: xcode9.4
3434
env:
3535
- OGRE_ENABLED=0
3636
- GSAGE_VERSION_BUILD=${TRAVIS_BUILD_NUMBER}

CMakeLists.txt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,8 @@ configure()
88

99
include(${CMAKE_SOURCE_DIR}/conanbuildinfo.cmake OPTIONAL)
1010

11-
if(CONAN_PACKAGE_NAME)
12-
set(CMAKE_INSTALL_PATH "./")
13-
include(cmake/ConanDependencies.cmake)
14-
else(CONAN_PACKAGE_NAME)
15-
set(CMAKE_INSTALL_PATH "/usr/local")
16-
include(cmake/Dependencies.cmake)
17-
endif(CONAN_PACKAGE_NAME)
11+
set(CMAKE_INSTALL_PATH "./")
12+
include(cmake/ConanDependencies.cmake)
1813

1914
process_templates()
2015

@@ -64,9 +59,15 @@ elseif(UNIX)
6459
set(CPACK_DEBIAN_PACKAGE_NAME "gsage")
6560
set(CPACK_DEBIAN_PACKAGE_VERSION "${GSAGE_VERSION_MAJOR}.${GSAGE_VERSION_MINOR}.${GSAGE_VERSION_PATCH}")
6661
set(CPACK_DEBIAN_PACKAGE_MAINTAINER "Artem Chernyshev")
62+
# additional dependencies for cef
63+
set(CPACK_DEBIAN_PACKAGE_DEPENDS "libcups2, libgconf-2-4, libgtk2.0-dev, libgdk-pixbuf2.0-dev, freeglut3-dev")
64+
65+
# other deps will be generated automatically
6766
set(CPACK_DEBIAN_PACKAGE_SHLIBDEPS ON)
6867
set(CPACK_DEBIAN_PACKAGE_DESCRIPTION "Open source game engine")
6968

69+
set(CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA "${gsage_SOURCE_DIR}/tools/postinst;${gsage_SOURCE_DIR}/tools/prerm")
70+
7071
set(CPACK_GENERATOR "DEB")
7172
endif(APPLE)
7273

Core/include/Filesystem.h

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,20 @@ namespace Gsage {
196196
return Poco::Path(path).getBaseName();
197197
}
198198

199+
/**
200+
* Same as Poco::Path::cacheHome
201+
*/
202+
inline std::string getCacheHome() const {
203+
return expand(Poco::Path::cacheHome());
204+
}
205+
206+
/**
207+
* Same as Poco::Path::expand
208+
*/
209+
inline std::string expand(const std::string& path) const {
210+
return Poco::Path::expand(path);
211+
}
212+
199213
/**
200214
* Flush all copy complete events
201215
*/

Core/src/EngineSystem.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ namespace Gsage
119119
}
120120

121121
mEngine->fireEvent(SystemChangeEvent(SystemChangeEvent::SYSTEM_STARTED, getName(), this));
122+
LOG(INFO) << "System " << getName() << " was started";
122123
return true;
123124
}
124125

PlugIns/CEF/src/CEFPlugin.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -917,13 +917,22 @@ namespace Gsage {
917917
std::stringstream ss;
918918
ss << dirname(path) << "/" << "cef.helper";
919919
CefString(&settings.browser_subprocess_path).FromASCII(ss.str().c_str());
920+
921+
if(!getcwd(path, sizeof(path)-1)) {
922+
LOG(ERROR) << "Failed to get current working directory";
923+
return false;
924+
}
925+
ss = std::stringstream();
926+
ss << path << "/locales";
927+
CefString(&settings.locales_dir_path) = ss.str().c_str();
920928
#elif GSAGE_PLATFORM == GSAGE_WIN32
921929
char filename[] = "cef.helper.exe";
922930
char fullFilename[MAX_PATH];
923931
GetFullPathName(filename, MAX_PATH, fullFilename, nullptr);
924932

925933
CefString(&settings.browser_subprocess_path).FromASCII(fullFilename);
926934
#endif
935+
CefString(&settings.cache_path) = (mFacade->filesystem()->getCacheHome() + "/gsage").c_str();
927936

928937
if(!mFacade->filesystem()->exists(CefString(&settings.browser_subprocess_path).ToString())) {
929938
LOG(ERROR) << "Failed to locate cef.helper executable " << CefString(&settings.browser_subprocess_path).ToString();

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ You can read more documentation on [http://engine.readthedocs.io/](http://engine
5151

5252
This engine supports three OS at the moment:
5353
* Windows, Visual Studio 2017 and later.
54-
* OSX, ci is using Xcode 9.1.
54+
* OSX, ci is using Xcode 9.4.
5555
* Linux, ci is using Ubuntu 16.04 with GCC 5.4.
5656

5757
There are plans to support iOS and Android.

cmake/Dependencies.cmake

Lines changed: 0 additions & 113 deletions
This file was deleted.

cmake/Functions.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ macro(configure)
8181
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3")
8282

8383
if(NOT APPLE)
84-
set(INSTALL_BINARY_DIR "local/bin/")
84+
set(INSTALL_BINARY_DIR "local/bin/gsage")
8585
set(INSTALL_LIB_DIR "local/lib/")
8686
set(INSTALL_PLUGINS_DIR "local/lib/gsage")
8787
set(INSTALL_RESOURCE_DIR "share/gsage/")

resources/editor/gsage.desktop.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
Version=${GSAGE_VERSION_MAJOR}.${GSAGE_VERSION_MINOR}.${GSAGE_VERSION_PATCH}
33
Name=GSAGE Editor
44
Comment=Open source game engine
5-
Exec=env GSAGE_RUN_DIRECTORY=/usr/share/gsage/ env GSAGE_PLUGINS_DIRECTORIES=/usr/local/lib/gsage/ /usr/local/bin/gsage
6-
Icon=/usr/share/gsage/resources/editor/editor.ico
5+
Exec=env GSAGE_RUN_DIRECTORY=/usr/share/gsage/ env GSAGE_PLUGINS_DIRECTORIES=/usr/local/lib/gsage/ /usr/local/bin/gsage/gsage
6+
Icon=/usr/share/gsage/resources/editor/gsage.ico
77
Terminal=false
88
Type=Application
99
Categories=Development

resources/scripts/editor/projectManager.lua

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ local ProjectManager = class(function(self)
191191
end
192192
self.awaitedSystems[event.systemID] = true
193193
local ready = true
194-
for _, started in pairs(self.awaitedSystems) do
194+
for id, started in pairs(self.awaitedSystems) do
195195
if started ~= true then
196196
ready = false
197197
break
@@ -263,7 +263,6 @@ function ProjectManager:create(settings, onProgress, onComplete)
263263
message(tostring(err), "#FF0000", true)
264264
end
265265
end
266-
267266
onComplete(success)
268267
end
269268

@@ -308,7 +307,7 @@ function ProjectManager:create(settings, onProgress, onComplete)
308307
end
309308
message(msg, color)
310309

311-
if percent == 100 then
310+
if percent >= 100 then
312311
finalize(true)
313312
end
314313
end
@@ -337,7 +336,7 @@ function ProjectManager:create(settings, onProgress, onComplete)
337336
message(msg, color)
338337
percent = percent + step / filecount
339338

340-
if percent == 100 then
339+
if percent >= 100 then
341340
finalize(true)
342341
end
343342
end
@@ -416,7 +415,6 @@ function ProjectManager:open(projectPath)
416415
log.error("Failed to open project " .. err)
417416
return false
418417
end
419-
log.info("Read project file")
420418

421419
self.openProjectFile = projectFile
422420
local sourcesDir = fs.path.join(self.openProjectFile.projectRoot, "sources")

0 commit comments

Comments
 (0)