Skip to content

Commit 8e795a7

Browse files
now supports "row" like a charm
1 parent 024094c commit 8e795a7

3 files changed

Lines changed: 13 additions & 12 deletions

File tree

packages/design-sdk

packages/designto-flutter/interpreter/cross-axis-alignment.interpret.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ export function interpretCrossAxisAlignment(
1717
case ReflectCrossAxisAlginment.center:
1818
return CrossAxisAlignment.center;
1919
default:
20-
return CrossAxisAlignment.center;
20+
return undefined;
2121
}
2222
}

packages/designto-flutter/make/column-row.make.ts

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,11 @@ export function makeRowColumn(
1515
const rowOrColumn: RowOrColumn =
1616
node.layoutMode === ReflectAxis.horizontal ? "Row" : "Column";
1717

18-
const mainAxisAlignment = interpretMainAxisAlignment(node.mainAxisAlignment);
19-
const mainAxisSize: flutter.MainAxisSize = interpretMainAxisSize(node);
18+
const _mainAxisAlignment = interpretMainAxisAlignment(node.mainAxisAlignment);
19+
const _mainAxisSize: flutter.MainAxisSize = interpretMainAxisSize(node);
20+
const _crossAxisAlignment = interpretCrossAxisAlignment(
21+
node.crossAxisAlignment
22+
);
2023

2124
// safely make childeren as list type
2225
children = makeSafelyAsList<flutter.Widget>(children);
@@ -25,18 +28,16 @@ export function makeRowColumn(
2528
case "Row":
2629
return new flutter.Row({
2730
children: children,
28-
mainAxisSize: mainAxisSize,
29-
mainAxisAlignment: mainAxisAlignment,
31+
mainAxisSize: _mainAxisSize,
32+
mainAxisAlignment: _mainAxisAlignment,
33+
crossAxisAlignment: _crossAxisAlignment,
3034
});
3135
case "Column":
32-
const crossAxisAlignment = interpretCrossAxisAlignment(
33-
node.crossAxisAlignment
34-
);
3536
return new flutter.Column({
3637
children: children,
37-
mainAxisSize: mainAxisSize,
38-
mainAxisAlignment: mainAxisAlignment,
39-
crossAxisAlignment: crossAxisAlignment,
38+
mainAxisSize: _mainAxisSize,
39+
mainAxisAlignment: _mainAxisAlignment,
40+
crossAxisAlignment: _crossAxisAlignment,
4041
});
4142
}
4243
}

0 commit comments

Comments
 (0)