Skip to content

Commit 8d4ac10

Browse files
committed
empty list indicates no available GPU types
1 parent 14de530 commit 8d4ac10

3 files changed

Lines changed: 4 additions & 14 deletions

File tree

src/discord-cluster-manager/api/main.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -442,16 +442,11 @@ async def get_gpus(leaderboard_name: str, db_context=Depends(get_db)) -> list[st
442442
if leaderboard_name not in leaderboard_names:
443443
raise HTTPException(status_code=400, detail="Invalid leaderboard name")
444444

445-
gpu_types = db.get_leaderboard_gpu_types(leaderboard_name)
446-
if gpu_types is None: # Handle case where function returns None
447-
return []
445+
return db.get_leaderboard_gpu_types(leaderboard_name)
448446

449447
except Exception as e:
450448
raise HTTPException(status_code=500, detail=f"Error fetching GPU data: {e}") from e
451449

452-
# Filter based on known runners
453-
return gpu_types
454-
455450

456451
@app.get("/submissions/{leaderboard_name}/{gpu_name}")
457452
async def get_submissions(

src/discord-cluster-manager/leaderboard_db.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ def get_leaderboards(self) -> list["LeaderboardItem"]:
368368

369369
return leaderboards
370370

371-
def get_leaderboard_gpu_types(self, leaderboard_name: str) -> List[str] | None:
371+
def get_leaderboard_gpu_types(self, leaderboard_name: str) -> List[str]:
372372
self.cursor.execute(
373373
"""
374374
SELECT *
@@ -382,12 +382,7 @@ def get_leaderboard_gpu_types(self, leaderboard_name: str) -> List[str] | None:
382382
(leaderboard_name,),
383383
)
384384

385-
gpu_types = [x[1] for x in self.cursor.fetchall()]
386-
387-
if gpu_types:
388-
return gpu_types
389-
else:
390-
return None
385+
return [x[1] for x in self.cursor.fetchall()]
391386

392387
def get_leaderboard(self, leaderboard_name: str) -> "LeaderboardItem":
393388
self.cursor.execute(

src/discord-cluster-manager/submission.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def get_avail_gpus(leaderboard: str, lb_db: LeaderboardDB):
9797
gpus = db.get_leaderboard_gpu_types(leaderboard)
9898

9999
if len(gpus) == 0:
100-
raise KernelBotError("❌ No available GPUs for Leaderboard " + f"`{leaderboard}`.")
100+
raise KernelBotError(f"❌ No available GPUs for Leaderboard `{leaderboard}`.")
101101

102102
return gpus
103103

0 commit comments

Comments
 (0)