Skip to content

Commit 3892756

Browse files
committed
include system info in printed report
1 parent 018a28e commit 3892756

2 files changed

Lines changed: 16 additions & 5 deletions

File tree

src/discord-cluster-manager/cogs/submit_cog.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ async def _handle_submission(
225225
verdict = short_report[-1][0]
226226
id_str = f"{verdict}" if submission_id == -1 else f"{verdict} #{submission_id}"
227227
await reporter.generate_report(
228-
f"{id_str} {name} on {gpu_type.name} ({launcher.name})", result.runs
228+
f"{id_str} {name} on {gpu_type.name} ({launcher.name})", result
229229
)
230230
except Exception as E:
231231
logger.error("Error generating report. Result: %s", result, exc_info=E)

src/discord-cluster-manager/report.py

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import consts
55
import discord
6-
from run_eval import CompileResult, EvalResult, RunResult
6+
from run_eval import CompileResult, EvalResult, FullResult, RunResult, SystemInfo
77
from utils import format_time
88

99

@@ -250,6 +250,16 @@ def log_one(base_name):
250250
return "❗ Could not find any benchmarks"
251251

252252

253+
def generate_system_info(system: SystemInfo):
254+
return f"""
255+
Running on:
256+
* GPU: `{system.gpu}`
257+
* CPU: `{system.cpu}`
258+
* Platform: `{system.platform}`
259+
* Torch: `{system.torch}`
260+
"""
261+
262+
253263
def generate_report(reporter: "RunResultReport", runs: dict[str, EvalResult]): # noqa: C901
254264
if "test" in runs:
255265
test_run = runs["test"]
@@ -379,7 +389,7 @@ async def update_title(self, new_title):
379389
def get_message(self):
380390
return str.join("\n", [f"**{self.title}**"] + self.lines)
381391

382-
async def generate_report(self, title: str, runs: dict[str, EvalResult]):
392+
async def generate_report(self, title: str, result: FullResult):
383393
raise NotImplementedError()
384394

385395
async def _update_message(self):
@@ -400,15 +410,16 @@ def __init__(
400410
async def _update_message(self):
401411
await self.root._update_message()
402412

403-
async def generate_report(self, title: str, runs: dict[str, EvalResult]):
413+
async def generate_report(self, title: str, result: FullResult):
404414
thread = await self.interaction.channel.create_thread(
405415
name=title,
406416
type=discord.ChannelType.private_thread,
407417
auto_archive_duration=1440,
408418
)
409419
await thread.add_user(self.interaction.user)
410420
report = RunResultReport()
411-
generate_report(report, runs)
421+
report.add_text(generate_system_info(result.system))
422+
generate_report(report, result.runs)
412423
message = ""
413424
for part in report.data:
414425
if isinstance(part, Text):

0 commit comments

Comments
 (0)