You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The VCDiffEncoder::EncodeToInterface method and the corresponding VCDiffDecoder::DecodeToInterface are currently private in their respective classes.
I don't see the rationale behind this, because the streaming versions of the encoder/decoder classes publicly expose methods that work with OutputStringInterface derived objects.
The aforementioned methods should be made public, because working with OutputStringInterface offers more flexibility.
The
VCDiffEncoder::EncodeToInterfacemethod and the correspondingVCDiffDecoder::DecodeToInterfaceare currentlyprivatein their respective classes.I don't see the rationale behind this, because the streaming versions of the encoder/decoder classes publicly expose methods that work with
OutputStringInterfacederived objects.The aforementioned methods should be made public, because working with
OutputStringInterfaceoffers more flexibility.