Fixes for int and byte tests

Signed-off-by: James Hamlin <jfhamlin@gmail.com>

Author: jfhamlin

pkg/lang/numbers.go

@@ -786,15 +786,27 @@ func BooleanCast(x any) bool {
 	return !IsNil(x)
 }
 
-func ByteCast(x any) byte {
-	if b, ok := x.(byte); ok {
-		return b
+func ByteCast(x any) int8 {
+	switch x := x.(type) {
+	case int8:
+		return x
+	case float32:
+		if x < math.MinInt8 || x > math.MaxInt8 {
+			panic(fmt.Errorf("value out of range for byte: %v", x))
+		}
+		return int8(x)
+	case float64:
+		if x < math.MinInt8 || x > math.MaxInt8 {
+			panic(fmt.Errorf("value out of range for byte: %v", x))
+		}
+		return int8(x)
 	}
+
 	l := AsInt64(x)
 	if l < math.MinInt8 || l > math.MaxInt8 {
 		panic(fmt.Errorf("value out of range for byte: %v", x))
 	}
-	return byte(l)
+	return int8(l)
 }
 
 func UncheckedByteCast(x any) byte {

pkg/runtime/rtcompat.go

@@ -102,7 +102,7 @@ func (rt *RTMethods) BooleanCast(x any) bool {
 	return lang.BooleanCast(x)
 }
 
-func (rt *RTMethods) ByteCast(x any) byte {
+func (rt *RTMethods) ByteCast(x any) int8 {
 	return lang.ByteCast(x)
 }
 

pkg/stdlib/clojure/core.glj

@@ -1397,10 +1397,7 @@
 (defn int?
   "Return true if x is a fixed precision integer"
   {:added "1.9"}
-  [x] (or (instance? go/int64 x)
-          (instance? Integer x)
-          (instance? Short x)
-          (instance? Byte x)))
+  [x] (or (instance? go/int x) (instance? go/uint x) (instance? go/byte x) (instance? go/int64 x) (instance? go/int32 x) (instance? go/int16 x) (instance? go/int8 x) (instance? go/uint64 x) (instance? go/uint32 x) (instance? go/uint16 x) (instance? go/uint8 x)))
 
 (defn pos-int?
   "Return true if x is a positive fixed precision integer"