fixup! fixup! Use subprocess's timeout feature instead of reinventing the wheel

Author: ngie-eign

git/cmd.py

@@ -109,7 +109,7 @@ def handle_process_output(
     stderr_handler: Union[None, Callable[[AnyStr], None], Callable[[List[AnyStr]], None]],
     finalizer: Union[None, Callable[[Union[Popen, "Git.AutoInterrupt"]], None]] = None,
     decode_streams: bool = True,
-    kill_after_timeout: Optional[float, int] = None,
+    kill_after_timeout: Optional[Union[float, int]] = None,
 ) -> None:
     R"""Register for notifications to learn that process output is ready to read, and
     dispatch lines to the respective line handlers.
@@ -335,7 +335,7 @@ def __init__(
         self,
         proc: subprocess.Popen | None,
         args: Any,
-        timeout: Optional[float, int] = None,
+        timeout: Optional[Union[float, int]] = None,
     ) -> None:
         self.proc = proc
         self.args = args
@@ -394,7 +394,7 @@ def __getattr__(self, attr: str) -> Any:
         return getattr(self.proc, attr)
 
     # TODO: Bad choice to mimic `proc.wait()` but with different args.
-    def wait(self, stderr: Optional[AnyStr] = b"", timeout: Optional[int, float] = None) -> int:
+    def wait(self, stderr: Optional[Union[str, bytes]] = b"", timeout: Optional[Union[int, float]] = None) -> int:
         """Wait for the process and return its status code.
 
         :param stderr:
@@ -1118,7 +1118,7 @@ def execute(
         as_process: bool = False,
         output_stream: Union[None, BinaryIO] = None,
         stdout_as_string: bool = True,
-        kill_after_timeout: Optional[float, int] = None,
+        kill_after_timeout: Optional[Union[float, int]] = None,
         with_stdout: bool = True,
         universal_newlines: bool = False,
         shell: Union[None, bool] = None,