Merge pull request #107 from iamvery/iamvery/errors

Make MismatchError a base Exception

Author: zerowidth

lib/scientist/experiment.rb

@@ -18,7 +18,7 @@ def self.new(name)
   end
 
   # A mismatch, raised when raise_on_mismatches is enabled.
-  class MismatchError < StandardError
+  class MismatchError < Exception
     attr_reader :name, :result
 
     def initialize(name, result)

test/scientist/experiment_test.rb

@@ -444,6 +444,20 @@ def @ex.raised(op, exception)
       assert_raises(Scientist::Experiment::MismatchError) { @ex.run }
     end
 
+    it "allows MismatchError to bubble up through bare rescues" do
+      Fake.raise_on_mismatches = true
+      @ex.use { "control" }
+      @ex.try { "candidate" }
+      runner = -> {
+        begin
+          @ex.run
+        rescue
+          # StandardError handled
+        end
+      }
+      assert_raises(Scientist::Experiment::MismatchError) { runner.call }
+    end
+
     describe "#raise_on_mismatches?" do
       it "raises when there is a mismatch if the experiment instance's raise on mismatches is enabled" do
         Fake.raise_on_mismatches = false