Merge pull request #144 from jejacks0n/no-set-default-for-module

Don’t set default when included in modules

Author: zerowidth

lib/scientist/experiment.rb

@@ -10,7 +10,7 @@ module Scientist::Experiment
   attr_accessor :raise_on_mismatches
 
   def self.included(base)
-    self.set_default(base)
+    self.set_default(base) if base.instance_of?(Class)
     base.extend RaiseOnMismatch
   end
 

test/scientist/experiment_test.rb

@@ -31,6 +31,24 @@ def publish(result)
     @ex = Fake.new
   end
 
+  it "sets the default on inclusion" do
+    klass = Class.new do
+      include Scientist::Experiment
+
+      def initialize(name)
+      end
+    end
+
+    assert_kind_of klass, Scientist::Experiment.new("hello")
+
+    Scientist::Experiment.set_default(nil)
+  end
+
+  it "doesn't set the default on inclusion when it's a module" do
+    Module.new { include Scientist::Experiment }
+    assert_kind_of Scientist::Default, Scientist::Experiment.new("hello")
+  end
+
   it "has a default implementation" do
     ex = Scientist::Experiment.new("hello")
     assert_kind_of Scientist::Default, ex