Rename error_compare to compare_errors

Author: izuzak

lib/scientist/experiment.rb

@@ -127,7 +127,7 @@ def compare(*args, &block)
   # and return true or false.
   #
   # Returns the block.
-  def error_compare(*args, &block)
+  def compare_errors(*args, &block)
     @_scientist_error_comparator = block
   end
 
@@ -174,7 +174,7 @@ def name
     "experiment"
   end
 
-  # Internal: compare two observations, using the configured compare and error_compare lambdas if present.
+  # Internal: compare two observations, using the configured compare and compare_errors lambdas if present.
   def observations_are_equivalent?(a, b)
     a.equivalent_to? b, @_scientist_comparator, @_scientist_error_comparator
   rescue StandardError => ex

lib/scientist/observation.rb

@@ -70,7 +70,7 @@ def equivalent_to?(other, comparator=nil, error_comparator=nil)
 
     if raised? || other.raised?
       if error_comparator
-        error_comparator.call(exception, other.exception)
+        return error_comparator.call(exception, other.exception)
       else
         return other.exception.class == exception.class &&
           other.exception.message == exception.message