Skip to content

Commit 783bcda

Browse files
committed
merge revision(s) 44861,44862: [Backport ruby#9493]
* gc.c (get_envparam_int): don't accept a value equals to lowerbound (changed by last commit) because "" or "foo" (not a number) strings are parsed as 0. They should be rejected. * gc.c (get_envparam_double): ditto. * gc.c (get_envparam_int): accept a value equals to lowerbound. * gc.c (get_envparam_int): correct warning messsages. * gc.c (get_envparam_double): ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@44868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
1 parent 7895c20 commit 783bcda

3 files changed

Lines changed: 21 additions & 7 deletions

File tree

ChangeLog

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
Fri Feb 7 04:19:19 2014 Koichi Sasada <ko1@atdot.net>
2+
3+
* gc.c (get_envparam_int): correct warning messsages.
4+
5+
* gc.c (get_envparam_double): ditto.
6+
7+
Fri Feb 7 04:19:19 2014 Koichi Sasada <ko1@atdot.net>
8+
9+
* gc.c (get_envparam_int): don't accept a value equals to lowerbound
10+
(changed by last commit) because "" or "foo" (not a number) strings
11+
are parsed as 0. They should be rejected.
12+
13+
* gc.c (get_envparam_double): ditto.
14+
115
Thu Feb 6 08:23:28 2014 Eric Wong <e@80x24.org>
216

317
* ext/thread/thread.c (rb_szqueue_max_set): use correct queue and
@@ -18,7 +32,7 @@ Thu Feb 6 11:23:59 2014 Koichi Sasada <ko1@atdot.net>
1832
Without this fix, the env variable RUBY_GC_OLDMALLOC_LIMIT
1933
does not work.
2034

21-
* gc.c (get_envparam_int): accept a value equals to lowerbounds.
35+
* gc.c (get_envparam_int): accept a value equals to lowerbound.
2236

2337
* gc.c (get_envparam_double): ditto.
2438

gc.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5649,13 +5649,13 @@ get_envparam_int(const char *name, unsigned int *default_value, int lower_bound)
56495649

56505650
if (ptr != NULL) {
56515651
val = atoi(ptr);
5652-
if (val >= lower_bound) {
5653-
if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%d (%d)\n", name, val, *default_value);
5652+
if (val > lower_bound) {
5653+
if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%d (default value: %d)\n", name, val, *default_value);
56545654
*default_value = val;
56555655
return 1;
56565656
}
56575657
else {
5658-
if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%d (%d), but ignored because lower than %d\n", name, val, *default_value, lower_bound);
5658+
if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%d (default value: %d) is ignored because it must be greater than %d.\n", name, val, *default_value, lower_bound);
56595659
}
56605660
}
56615661
return 0;
@@ -5669,13 +5669,13 @@ get_envparam_double(const char *name, double *default_value, double lower_bound)
56695669

56705670
if (ptr != NULL) {
56715671
val = strtod(ptr, NULL);
5672-
if (val >= lower_bound) {
5672+
if (val > lower_bound) {
56735673
if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%f (%f)\n", name, val, *default_value);
56745674
*default_value = val;
56755675
return 1;
56765676
}
56775677
else {
5678-
if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%f (%f), but ignored because lower than %f\n", name, val, *default_value, lower_bound);
5678+
if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%f (default value: %f) is ignored because it must be greater than %f.\n", name, val, *default_value, lower_bound);
56795679
}
56805680
}
56815681
return 0;

version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#define RUBY_VERSION "2.1.1"
22
#define RUBY_RELEASE_DATE "2014-02-07"
3-
#define RUBY_PATCHLEVEL 27
3+
#define RUBY_PATCHLEVEL 28
44

55
#define RUBY_RELEASE_YEAR 2014
66
#define RUBY_RELEASE_MONTH 2

0 commit comments

Comments
 (0)