Skip to content

Commit 02dcfb7

Browse files
committed
merge revision(s) r49071,r49072,r49073,r49078: [Backport ruby#10550]
* lib/resolv.rb (Resolv::DNS::Name): names with different dots should be different. * lib/resolv.rb (Resolv::DNS::Name#==): DNS is case-insensitive, so the comparison should be case-insensitive as well. [ruby-core:66498] [Bug ruby#10550] * lib/resolv.rb (Resolv::DNS::Name#==): Compare an array of Label:Str objects. Label#Str#== is case-insensitive. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@49775 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
1 parent 13112e5 commit 02dcfb7

4 files changed

Lines changed: 34 additions & 4 deletions

File tree

ChangeLog

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
Sat Feb 28 02:13:17 2015 Tanaka Akira <akr@fsij.org>
2+
3+
* lib/resolv.rb (Resolv::DNS::Name#==): Compare an array of Label:Str
4+
objects. Label#Str#== is case-insensitive.
5+
6+
Sat Feb 28 02:13:17 2015 Ben Miller <bmiller@rackspace.com>
7+
8+
* lib/resolv.rb (Resolv::DNS::Name#==): DNS is case-insensitive, so the
9+
comparison should be case-insensitive as well.
10+
[ruby-core:66498] [Bug #10550]
11+
12+
Sat Feb 28 02:13:17 2015 Nobuyoshi Nakada <nobu@ruby-lang.org>
13+
14+
* lib/resolv.rb (Resolv::DNS::Name): names with different dots
15+
should be different.
16+
117
Thu Feb 19 19:14:34 2015 NARUSE, Yui <naruse@ruby-lang.org>
218

319
* lib/net/http/response.rb (Net::HTTPResponse): require one or more

lib/resolv.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1240,7 +1240,8 @@ def absolute?
12401240

12411241
def ==(other) # :nodoc:
12421242
return false unless Name === other
1243-
return @labels.join == other.to_a.join && @absolute == other.absolute?
1243+
return false unless @absolute == other.absolute?
1244+
return @labels == other.to_a
12441245
end
12451246

12461247
alias eql? == # :nodoc:

test/resolv/test_dns.rb

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,4 +175,17 @@ def test_invalid_byte_comment
175175
end
176176
end
177177
end
178+
179+
def test_dots_diffences
180+
name1 = Resolv::DNS::Name.create("example.org")
181+
name2 = Resolv::DNS::Name.create("ex.ampl.eo.rg")
182+
assert_not_equal(name1, name2, "different dots")
183+
end
184+
185+
def test_case_insensitive_name
186+
bug10550 = '[ruby-core:66498] [Bug #10550]'
187+
lower = Resolv::DNS::Name.create("ruby-lang.org")
188+
upper = Resolv::DNS::Name.create("Ruby-Lang.org")
189+
assert_equal(lower, upper, bug10550)
190+
end
178191
end

version.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
#define RUBY_VERSION "2.1.5"
2-
#define RUBY_RELEASE_DATE "2015-02-19"
3-
#define RUBY_PATCHLEVEL 299
2+
#define RUBY_RELEASE_DATE "2015-02-28"
3+
#define RUBY_PATCHLEVEL 300
44

55
#define RUBY_RELEASE_YEAR 2015
66
#define RUBY_RELEASE_MONTH 2
7-
#define RUBY_RELEASE_DAY 19
7+
#define RUBY_RELEASE_DAY 28
88

99
#include "ruby/version.h"
1010

0 commit comments

Comments
 (0)