count_rows_queries

BarShauli555 · BarShauli555 · commit 98dc355804ab · 2024-08-18T15:26:36.000+03:00
diff --git a/go/logic/inspect.go b/go/logic/inspect.go
@@ -554,7 +554,7 @@ func (this *Inspector) CountTableRows(ctx context.Context) error {
 		return err
 	}
 
-	query := fmt.Sprintf(`select /* gh-ost */ count(*) as count_rows from %s.%s`, sql.EscapeName(this.migrationContext.DatabaseName), sql.EscapeName(this.migrationContext.OriginalTableName))
+	query := fmt.Sprintf(`select /* gh-ost */ table_rows as count_rows from information_schema.tables where table_schema="%s" and table_name="%s"`, sql.EscapeName(this.migrationContext.DatabaseName), sql.EscapeName(this.migrationContext.OriginalTableName))
 	var rowsEstimate int64
 	if err := conn.QueryRowContext(ctx, query).Scan(&rowsEstimate); err != nil {
 		if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {

Original file line number	Diff line number	Diff line change
`@@ -554,7 +554,7 @@ func (this *Inspector) CountTableRows(ctx context.Context) error {`
`554`	`554`	`return err`
`555`	`555`	`}`
`556`	`556`
`557`		- query := fmt.Sprintf(`select /* gh-ost / count() as count_rows from %s.%s`, sql.EscapeName(this.migrationContext.DatabaseName), sql.EscapeName(this.migrationContext.OriginalTableName))
	`557`	+ query := fmt.Sprintf(`select /* gh-ost */ table_rows as count_rows from information_schema.tables where table_schema="%s" and table_name="%s"`, sql.EscapeName(this.migrationContext.DatabaseName), sql.EscapeName(this.migrationContext.OriginalTableName))
`558`	`558`	`var rowsEstimate int64`
`559`	`559`	`if err := conn.QueryRowContext(ctx, query).Scan(&rowsEstimate); err != nil {`
`560`	`560`	`if errors.Is(err, context.Canceled) \|\| errors.Is(err, context.DeadlineExceeded) {`