Initial updates from PR review

Author: lindseywild

.github/actions/file/action.yml

@@ -14,7 +14,7 @@ inputs:
   cached_filings:
     description: "Cached filings from previous runs, as stringified JSON. Without this, duplicate issues may be filed."
     required: false
-  screenshot_repo:
+  screenshot_repository:
     description: "Repository (with owner) where screenshots are stored on the gh-cache branch. Defaults to the 'repository' input if not set. Required if issues are open in a different repo to construct proper screenshot URLs."
     required: false
 

.github/actions/file/src/index.ts

@@ -20,13 +20,15 @@ export default async function () {
   );
   const repoWithOwner = core.getInput("repository", { required: true });
   const token = core.getInput("token", { required: true });
-  const screenshotRepo = core.getInput("screenshot_repo", { required: false }) || repoWithOwner;
+  const screenshotRepo =
+    core.getInput("screenshot_repository", { required: false }) ||
+    repoWithOwner;
   const cachedFilings: (ResolvedFiling | RepeatedFiling)[] = JSON.parse(
     core.getInput("cached_filings", { required: false }) || "[]"
   );
   core.debug(`Input: 'findings: ${JSON.stringify(findings)}'`);
   core.debug(`Input: 'repository: ${repoWithOwner}'`);
-  core.debug(`Input: 'screenshot_repo: ${screenshotRepo}'`);
+  core.debug(`Input: 'screenshot_repository: ${screenshotRepo}'`);
   core.debug(`Input: 'cached_filings: ${JSON.stringify(cachedFilings)}'`);
 
   const octokit = new OctokitWithThrottling({

.github/actions/find/src/findForUrl.ts

@@ -39,6 +39,8 @@ export async function findForUrl(
       if (!fs.existsSync(SCREENSHOT_DIR)) {
         fs.mkdirSync(SCREENSHOT_DIR, { recursive: true });
         console.log(`Created screenshot directory: ${SCREENSHOT_DIR}`);
+      } else {
+        console.log(`Using existing screenshot directory ${SCREENSHOT_DIR}`);
       }
 
       try {

action.yml

@@ -93,7 +93,7 @@ runs:
         repository: ${{ inputs.repository }}
         token: ${{ inputs.token }}
         cached_filings: ${{ steps.normalize_cache.outputs.value }}
-        screenshot_repo: ${{ github.repository }}
+        screenshot_repository: ${{ github.repository }}
     - if: ${{ steps.file.outputs.filings }}
       name: Get issues from filings
       id: get_issues_from_filings