PR feedback

Author: abdulahmad307

.github/actions/find/src/findForUrl.ts

@@ -48,8 +48,6 @@ export async function findForUrl(
             plugin,
             page,
             addFinding,
-            // - this will be coming soon
-            // runAxeScan: () => runAxeScan({page, includeScreenshots, findings}),
           })
         } else {
           core.info(`Skipping plugin ${plugin.name} because it is not included in the 'scans' input`)

.github/actions/find/src/pluginManager.ts

@@ -13,11 +13,9 @@ const __dirname = path.dirname(__filename)
 type PluginDefaultParams = {
   page: playwright.Page
   addFinding: (findingData: Finding) => void
-  // - this will be coming soon
-  // runAxeScan: (options: {includeScreenshots: boolean; page: playwright.Page; findings: Finding[]}) => Promise<void>
 }
 
-export type Plugin = {
+type Plugin = {
   name: string
   default: (options: PluginDefaultParams) => Promise<void>
 }

.github/actions/find/src/types.d.ts

@@ -7,7 +7,7 @@ export type Finding = {
   solutionShort: string
   solutionLong?: string
   screenshotId?: string
-  ruleId: string
+  ruleId?: string
 }
 
 export type Cookie = {