Extracts generareScreenshots into another function

Author: lindseywild

.github/actions/find/src/findForUrl.ts

@@ -2,16 +2,7 @@ import type { Finding } from './types.d.js';
 import AxeBuilder from '@axe-core/playwright'
 import playwright from 'playwright';
 import { AuthContext } from './AuthContext.js';
-import fs from "node:fs";
-import path from "node:path";
-import crypto from "node:crypto";
-
-// Use GITHUB_WORKSPACE to ensure screenshots are saved in the workflow workspace root
-// where the artifact upload step can find them
-const SCREENSHOT_DIR = path.join(
-  process.env.GITHUB_WORKSPACE || process.cwd(),
-  ".screenshots",
-);
+import { generateScreenshots } from "./generateScreenshots.js";
 
 export async function findForUrl(
   url: string,
@@ -31,33 +22,10 @@ export async function findForUrl(
   let findings: Finding[] = [];
   try {
     const rawFindings = await new AxeBuilder({ page }).analyze();
-    let screenshotId: string | undefined;
 
+    let screenshotId: string | undefined;
     if (includeScreenshots) {
-      // Ensure screenshot directory exists
-      if (!fs.existsSync(SCREENSHOT_DIR)) {
-        fs.mkdirSync(SCREENSHOT_DIR, { recursive: true });
-        console.log(`Created screenshot directory: ${SCREENSHOT_DIR}`);
-      } else {
-        console.log(`Using existing screenshot directory ${SCREENSHOT_DIR}`);
-      }
-
-      try {
-        const screenshotBuffer = await page.screenshot({
-          fullPage: true,
-          type: "png",
-        });
-
-        screenshotId = crypto.randomUUID();
-        const filename = `${screenshotId}.png`;
-        const filepath = path.join(SCREENSHOT_DIR, filename);
-
-        fs.writeFileSync(filepath, screenshotBuffer);
-        console.log(`Screenshot saved: ${filename}`);
-      } catch (error) {
-        console.error("Failed to capture/save screenshot:", error);
-        screenshotId = undefined;
-      }
+      screenshotId = await generateScreenshots(page);
     }
 
     findings = rawFindings.violations.map((violation) => ({

.github/actions/find/src/generateScreenshot.ts

@@ -0,0 +1,41 @@
+import fs from "node:fs";
+import path from "node:path";
+import crypto from "node:crypto";
+import type { Page } from "playwright";
+
+// Use GITHUB_WORKSPACE to ensure screenshots are saved in the workflow workspace root
+// where the artifact upload step can find them
+const SCREENSHOT_DIR = path.join(
+  process.env.GITHUB_WORKSPACE || process.cwd(),
+  ".screenshots",
+);
+
+export const generateScreenshots = async function (page: Page) {
+  let screenshotId: string | undefined;
+  // Ensure screenshot directory exists
+  if (!fs.existsSync(SCREENSHOT_DIR)) {
+    fs.mkdirSync(SCREENSHOT_DIR, { recursive: true });
+    console.log(`Created screenshot directory: ${SCREENSHOT_DIR}`);
+  } else {
+    console.log(`Using existing screenshot directory ${SCREENSHOT_DIR}`);
+  }
+
+  try {
+    const screenshotBuffer = await page.screenshot({
+      fullPage: true,
+      type: "png",
+    });
+
+    screenshotId = crypto.randomUUID();
+    const filename = `${screenshotId}.png`;
+    const filepath = path.join(SCREENSHOT_DIR, filename);
+
+    fs.writeFileSync(filepath, screenshotBuffer);
+    console.log(`Screenshot saved: ${filename}`);
+  } catch (error) {
+    console.error("Failed to capture/save screenshot:", error);
+    screenshotId = undefined;
+  }
+
+  return screenshotId
+}