fetch: fix wrong evaluation order in URL trailing-slash trimming

cuiweixie · gitster · commit f87593ab1a70 · 2026-02-25T09:12:31.000-08:00
if i == -1, url[i] will be UB.

Signed-off-by: cuiweixie &lt;cuiweixie@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/fetch.c b/builtin/fetch.c
@@ -761,7 +761,7 @@ static void display_state_init(struct display_state *display_state, struct ref *
 		display_state->url = xstrdup("foreign");
 
 	display_state->url_len = strlen(display_state->url);
-	for (i = display_state->url_len - 1; display_state->url[i] == '/' && 0 <= i; i--)
+	for (i = display_state->url_len - 1; 0 <= i && display_state->url[i] == '/'; i--)
 		;
 	display_state->url_len = i + 1;
 	if (4 < i && !strncmp(".git", display_state->url + i - 3, 4))

Original file line number	Diff line number	Diff line change
`@@ -761,7 +761,7 @@ static void display_state_init(struct display_state display_state, struct ref `
`761`	`761`	`display_state->url = xstrdup("foreign");`
`762`	`762`
`763`	`763`	`display_state->url_len = strlen(display_state->url);`
`764`		`- for (i = display_state->url_len - 1; display_state->url[i] == '/' && 0 <= i; i--)`
	`764`	`+ for (i = display_state->url_len - 1; 0 <= i && display_state->url[i] == '/'; i--)`
`765`	`765`	`;`
`766`	`766`	`display_state->url_len = i + 1;`
`767`	`767`	`if (4 < i && !strncmp(".git", display_state->url + i - 3, 4))`