Skip to content

Commit e16ac6c

Browse files
ttaylorrgitster
authored andcommitted
t/t5319-multi-pack-index.sh: drop early 'test_done'
In 6ce9d55 (midx-write: skip rewriting MIDX with `--stdin-packs` unless needed, 2025-12-10), an extra 'test_done' was added, causing the test script to finish before having run all of its tests. Dropping this extraneous 'test_done' exposes a bug from commit 6ce9d55 that causes a subsequent test to fail. Mark that test with a 'test_expect_failure' for now, and the subsequent commit will explain and fix the bug. Signed-off-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent cc06d7e commit e16ac6c

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

t/t5319-multi-pack-index.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -415,8 +415,6 @@ test_expect_success 'up-to-date multi-pack-index is retained' '
415415
)
416416
'
417417

418-
test_done
419-
420418
test_expect_success 'verify multi-pack-index success' '
421419
git multi-pack-index verify --object-dir=$objdir
422420
'
@@ -565,7 +563,7 @@ test_expect_success 'git fsck suppresses MIDX output with --no-progress' '
565563
! grep "Verifying object offsets" err
566564
'
567565

568-
test_expect_success 'corrupt MIDX is not reused' '
566+
test_expect_failure 'corrupt MIDX is not reused' '
569567
corrupt_midx_and_verify $MIDX_BYTE_OFFSET "\377" $objdir \
570568
"incorrect object offset" &&
571569
git multi-pack-index write 2>err &&

0 commit comments

Comments
 (0)