Skip to content

Commit 97121bb

Browse files
committed
gitk: fix msgfmt being required
While the Meson build instructions already handle the case where msgfmt wasn't found, we forgot to mark the dependency itself as optional. This causes an error in case the executable could not be found: Project name: gitk Project version: undefined Program sh found: YES (C:\Program Files\Git\bin\sh.EXE) Program wish found: YES (C:\Program Files\Git\mingw64\bin\wish.EXE) Program chmod found: YES (C:\Program Files\Git\usr\bin\chmod.EXE) Program mv found: YES (C:\Program Files\Git\usr\bin\mv.EXE) Program sed found: YES (C:\Program Files\Git\usr\bin\sed.EXE) Program msgfmt found: NO subprojects\gitk\meson.build:28:3: ERROR: Program 'msgfmt' not found or not executable Fix the issue by adding the `required: false` parameter. Signed-off-by: Patrick Steinhardt <ps@pks.im>
1 parent 28f96e0 commit 97121bb

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

meson.build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ custom_target(
2525
install_dir: get_option('bindir'),
2626
)
2727

28-
if find_program('msgfmt').found()
28+
if find_program('msgfmt', required: false).found()
2929
subdir('po')
3030
endif

0 commit comments

Comments
 (0)