t9200: replace test -f with modern path helper

pabloosabaterr · gitster · commit 90725761237c · 2026-03-12T10:39:04.000-07:00
Replace old style 'test -f' with helper
'test_path_is_file', which make debugging
a failing test easier by loudly reporting
what expectation was not met.

Signed-off-by: Pablo Sabater &lt;pabloosabaterr@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
@@ -307,7 +307,7 @@ test_expect_success 're-commit a removed filename which remains in CVS attic' '
 	git commit -m "Added attic_gremlin" &&
 	git cvsexportcommit -w "$CVSWORK" -c HEAD &&
 	(cd "$CVSWORK" && cvs -Q update -d) &&
-	test -f "$CVSWORK/attic_gremlin"
+	test_path_is_file "$CVSWORK/attic_gremlin"
 '
 
 # the state of the CVS sandbox may be indeterminate for ' space'

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ test_expect_success 're-commit a removed filename which remains in CVS attic' '`
`307`	`307`	`git commit -m "Added attic_gremlin" &&`
`308`	`308`	`git cvsexportcommit -w "$CVSWORK" -c HEAD &&`
`309`	`309`	`(cd "$CVSWORK" && cvs -Q update -d) &&`
`310`		`- test -f "$CVSWORK/attic_gremlin"`
	`310`	`+ test_path_is_file "$CVSWORK/attic_gremlin"`
`311`	`311`	`'`
`312`	`312`
`313`	`313`	`# the state of the CVS sandbox may be indeterminate for ' space'`