t9812: modernize test path helpers

sneaky-potato · gitster · commit 580d86576a34 · 2026-02-12T11:08:29.000-08:00
Replace assertion-style 'test -f' checks with Git's
test_path_is_file() helper for clearer failures and
consistency.

Signed-off-by: Ashwani Kumar Kamal &lt;ashwanikamal.im421@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t9812-git-p4-wildcards.sh b/t/t9812-git-p4-wildcards.sh
@@ -30,13 +30,13 @@ test_expect_success 'wildcard files git p4 clone' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$git" &&
-		test -f file-wild#hash &&
+		test_path_is_file file-wild#hash &&
 		if test_have_prereq !MINGW,!CYGWIN
 		then
-			test -f file-wild\*star
+			test_path_is_file file-wild\*star
 		fi &&
-		test -f file-wild@at &&
-		test -f file-wild%percent
+		test_path_is_file file-wild@at &&
+		test_path_is_file file-wild%percent
 	)
 '
 

Original file line number	Diff line number	Diff line change
`@@ -30,13 +30,13 @@ test_expect_success 'wildcard files git p4 clone' '`
`30`	`30`	`test_when_finished cleanup_git &&`
`31`	`31`	`(`
`32`	`32`	`cd "$git" &&`
`33`		`- test -f file-wild#hash &&`
	`33`	`+ test_path_is_file file-wild#hash &&`
`34`	`34`	`if test_have_prereq !MINGW,!CYGWIN`
`35`	`35`	`then`
`36`		`- test -f file-wild\*star`
	`36`	`+ test_path_is_file file-wild\*star`
`37`	`37`	`fi &&`
`38`		`- test -f file-wild@at &&`
`39`		`- test -f file-wild%percent`
	`38`	`+ test_path_is_file file-wild@at &&`
	`39`	`+ test_path_is_file file-wild%percent`
`40`	`40`	`)`
`41`	`41`	`'`
`42`	`42`