update-ref --stdin: skip trailing space

Author: j6t

builtin/update-ref.c

@@ -47,6 +47,14 @@ static const char *parse_arg(const char *next, struct strbuf *arg)
 	return next;
 }
 
+static const char *skip_trailing_space(const char *next)
+{
+	if (line_termination)
+		while (*next && *next != line_termination && isspace(*next))
+			next++;
+	return next;
+}
+
 /*
  * Parse the reference name immediately after "command SP".  If not
  * -z, then handle C-quoting.  Return a pointer to a newly allocated
@@ -263,6 +271,7 @@ static void parse_cmd_update(struct ref_transaction *transaction,
 	have_old = !parse_next_oid(&next, end, &old_oid, "update", refname,
 				   PARSE_SHA1_OLD);
 
+	next = skip_trailing_space(next);
 	if (*next != line_termination)
 		die("update %s: extra input: %s", refname, next);
 
@@ -351,6 +360,7 @@ static void parse_cmd_create(struct ref_transaction *transaction,
 	if (is_null_oid(&new_oid))
 		die("create %s: zero <new-oid>", refname);
 
+	next = skip_trailing_space(next);
 	if (*next != line_termination)
 		die("create %s: extra input: %s", refname, next);
 

t/t1400-update-ref.sh

@@ -629,7 +629,7 @@ test_expect_success 'stdin fails create with no new value' '
 test_expect_success 'stdin fails create with too many arguments' '
 	echo "create $a $m $m" >stdin &&
 	test_must_fail git update-ref --stdin <stdin 2>err &&
-	grep "fatal: create $a: extra input:  $m" err
+	grep "fatal: create $a: extra input: $m" err
 '
 
 test_expect_success 'stdin fails update with no ref' '
@@ -647,7 +647,7 @@ test_expect_success 'stdin fails update with no new value' '
 test_expect_success 'stdin fails update with too many arguments' '
 	echo "update $a $m $m $m" >stdin &&
 	test_must_fail git update-ref --stdin <stdin 2>err &&
-	grep "fatal: update $a: extra input:  $m" err
+	grep "fatal: update $a: extra input: $m" err
 '
 
 test_expect_success 'stdin fails delete with no ref' '