Skip to content

Commit 05f28e4

Browse files
derrickstoleegitster
authored andcommitted
scalar: use index.skipHash=true for performance
The index.skipHash config option has been set to 'false' by Scalar since 4933152 (scalar: enable path-walk during push via config, 2025-05-16) but that commit message is trying to communicate the exact opposite: that the 'true' value is what we want instead. This means that we've been disabling this performance benefit for Scalar repos unintentionally. Fix this issue before we add justification for the config options set in this list. Oddly, enabling index.skipHash causes a test issue during 'test_commit' in one of the Scalar tests when GIT_TEST_SPLIT_INDEX is enabled (as caught by the linux-test-vars build). I'm fixing the test by disabling the environment variable, but the issue should be resolved in a series focused on the split index. Signed-off-by: Derrick Stolee <stolee@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 48695fc commit 05f28e4

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

scalar.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ static int set_recommended_config(int reconfigure)
160160
{ "credential.validate", "false", 1 }, /* GCM4W-only */
161161
{ "gc.auto", "0", 1 },
162162
{ "gui.GCWarning", "false", 1 },
163-
{ "index.skipHash", "false", 1 },
163+
{ "index.skipHash", "true", 1 },
164164
{ "index.threads", "true", 1 },
165165
{ "index.version", "4", 1 },
166166
{ "merge.stat", "false", 1 },

t/t9210-scalar.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,10 @@ test_expect_success 'scalar reconfigure --all with includeIf.onbranch' '
246246
'
247247

248248
test_expect_success 'scalar reconfigure --all with detached HEADs' '
249+
# This test demonstrates an issue with index.skipHash=true and
250+
# this test variable for the split index. Disable the test variable.
251+
sane_unset GIT_TEST_SPLIT_INDEX &&
252+
249253
repos="two three four" &&
250254
for num in $repos
251255
do

0 commit comments

Comments
 (0)