Skip to content

Commit 504d879

Browse files
committed
add a note why the shouldGenerateOutputFile switch is missing
1 parent 451caa1 commit 504d879

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

src/main/java/io/github/git/commit/id/gradle/plugin/GitCommitIdPluginGenerationTask.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,10 @@ public File getDotGitDirectory() {
280280

281281
@Override
282282
public boolean shouldGenerateGitPropertiesFile() {
283+
// This plugin currently relies on the fact that the
284+
// output properties file was generated.
285+
// Otherwise, the properties are not exposed as
286+
// extra project properties via the PropertyExposingClosure.
283287
return true;
284288
}
285289

src/main/java/io/github/git/commit/id/gradle/plugin/GitCommitIdPluginOutputSettingsExtension.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,12 @@ public abstract class GitCommitIdPluginOutputSettingsExtension {
6868
// @OutputFile
6969
public abstract RegularFileProperty getOutputFile();
7070

71+
// This plugin currently relies on the fact that the
72+
// output properties file was generated.
73+
// Otherwise, the properties are not exposed as
74+
// extra project properties via the PropertyExposingClosure.
75+
// So the switch shouldGenerateOutputFile is intentionally missing!
76+
7177
/**
7278
* Configuration option to enable or disable unicode escaping in the generated properties file.
7379
*

0 commit comments

Comments
 (0)