instead of having some 'internal' git properties file, just drop the idea of having the properties optional so the closure to expose them to the project can remain working

Author: TheSnoozer

src/main/java/io/github/git/commit/id/gradle/plugin/GitCommitIdPlugin.java

@@ -92,9 +92,8 @@ public String toString() {
         private Properties getProps() {
             try {
                 final Properties p = GenericFileManager.readPropertiesAsUtf8(
-                    // task.getGitCommitIdPluginOutputSettingsExtension().getOutputFormat().get(),
-                    CommitIdPropertiesOutputFormat.PROPERTIES,
-                    task.getInternalOutput().getAsFile()
+                    task.getGitCommitIdPluginOutputSettingsExtension().getOutputFormat().get(),
+                    task.getOutput().getAsFile().get()
                 );
                 return p;
             } catch (GitCommitIdExecutionException e) {

src/main/java/io/github/git/commit/id/gradle/plugin/GitCommitIdPluginGenerationTask.java

@@ -29,7 +29,6 @@
 import javax.annotation.Nullable;
 import org.gradle.api.DefaultTask;
 import org.gradle.api.file.DirectoryProperty;
-import org.gradle.api.file.RegularFile;
 import org.gradle.api.file.RegularFileProperty;
 import org.gradle.api.plugins.ExtensionAware;
 import org.gradle.api.tasks.CacheableTask;
@@ -46,7 +45,6 @@
 import pl.project13.core.git.GitDescribeConfig;
 import pl.project13.core.log.LogInterface;
 import pl.project13.core.util.BuildFileChangeListener;
-import pl.project13.core.util.GenericFileManager;
 
 /**
  * The task that generates the "git" information.
@@ -125,11 +123,6 @@ public RegularFileProperty getOutput() {
         return getGitCommitIdPluginOutputSettingsExtension().getOutputFile();
     }
 
-    @OutputFile
-    public RegularFile getInternalOutput() {
-        return getProject().getLayout().getBuildDirectory().file("internal_git.properties").get();
-    }
-
     /**
      * The task action that ties it all together and runs the underlying logic of gathering the data
      * and exporting it to the relevant locations.
@@ -287,8 +280,7 @@ public File getDotGitDirectory() {
 
             @Override
             public boolean shouldGenerateGitPropertiesFile() {
-                return getGitCommitIdPluginOutputSettingsExtension()
-                  .getShouldGenerateOutputFile().get();
+                return true;
             }
 
             @Override
@@ -355,17 +347,6 @@ public boolean shouldPropertiesEscapeUnicode() {
         try {
             Properties properties = new Properties();
             pl.project13.core.GitCommitIdPlugin.runPlugin(cb, properties);
-
-            GenericFileManager.dumpProperties(
-                null,
-                CommitIdPropertiesOutputFormat.PROPERTIES,
-                getInternalOutput().getAsFile(),
-                StandardCharsets.UTF_8,
-                false,
-                null,
-                properties
-            );
-
             // When we want to use it as TaskInput or something,
             // it should be convert to a hashmap, excluding build_time
             /*

src/main/java/io/github/git/commit/id/gradle/plugin/GitCommitIdPluginOutputSettingsExtension.java

@@ -49,7 +49,7 @@ public abstract class GitCommitIdPluginOutputSettingsExtension {
      * <pre>
      * gitCommitId {
      *     outputSettings {
-     *         shouldGenerateOutputFile.set(true)
+     *         outputFile.set(project.getLayout().buildDirectory.file("git.properties"))
      *     }
      * }
      * </pre>
@@ -58,23 +58,11 @@ public abstract class GitCommitIdPluginOutputSettingsExtension {
      */
     public static final String NAME = "outputSettings";
 
-    /**
-     * Configuration option to enable or disable the generation of an output file.
-     * To enable such generation, set this to {@code true}.
-     * By default, this setting is disabled (set to {@code false}).
-     *
-     * <p>To configure the location of the output file refer to
-     * {@link #getOutputFile()}, to configure the format (json, properties, ...)
-     * of this file refer to {@link #getOutputFormat()}.
-     */
-    public abstract Property<Boolean> getShouldGenerateOutputFile();
-
     /**
      * Configuration location of an output file that can be generated by the plugin.
      * Defaults to {@code ${project.getBuildDir()}/git.properties}, formatted as "properties" file.
      *
-     * <p>To enable or disable the generation of such output file refer to
-     * {@link #getShouldGenerateOutputFile()}, to configure the format (json, properties, ...)
+     * <p>To configure the format (json, properties, ...)
      * of this file refer to {@link #getOutputFormat()}.
      */
     // @OutputFile
@@ -107,9 +95,7 @@ public abstract class GitCommitIdPluginOutputSettingsExtension {
     /**
      * Allows to configure the format (json, properties, ...) in which the output file
      * should be saved in.
-     * To enable or disable the generation of such properties file refer to
-     * {@link #getShouldGenerateOutputFile()} and to configure the location
-     * of the properties file refer to {@link #getOutputFile()}.
+     * To configure the location of the properties file refer to {@link #getOutputFile()}.
      *
      * <p>By default will assume that the desired format is "properties".
      */
@@ -125,8 +111,6 @@ public ProjectLayout getProjectLayout() {
      */
     @Inject
     public GitCommitIdPluginOutputSettingsExtension() {
-        getShouldGenerateOutputFile()
-            .convention(false);
         getOutputFile().convention(
             getProjectLayout().getBuildDirectory().file("git.properties"));
         getShouldEscapedUnicodeForPropertiesOutput().convention(false);

src/test/groovy/io.github.git.commit.id.gradle.plugin/GradleIntegrationTest.groovy

@@ -81,19 +81,6 @@ class GradleIntegrationTest extends AbstractGradleTest {
         // https://docs.gradle.org/current/userguide/build_cache.html#sec:build_cache_enable
         new File(projectDir, "gradle.properties") << "org.gradle.caching=true"
 
-        and: "we produce a git properties file"
-        new File(projectDir, "build.gradle").withWriterAppend("UTF-8") {
-            it.write(
-                    """
-                    ${GitCommitIdPluginExtension.NAME} {
-                        outputSettings {
-                            shouldGenerateOutputFile.set(true)
-                        }
-                    }
-                    """.stripIndent()
-            )
-        }
-
         when: "running the plugin"
         def runner = createRunner(projectDir)