feat!: Remove enable_logs

Author: sl0thentr0py

sentry-rails/lib/sentry/rails/configuration.rb

@@ -35,8 +35,6 @@ class Configuration
     end
 
     after(:configured) do
-      rails.structured_logging.enabled = enable_logs if rails.structured_logging.enabled.nil?
-
       collection = data_collection.url_query_params
       if collection.mode == :deny_list
         filter_parameters = ::Rails.application.config.filter_parameters.select do |filter|
@@ -226,7 +224,7 @@ class StructuredLoggingConfiguration
       }.freeze
 
       def initialize
-        @enabled = nil
+        @enabled = true
         @subscribers = DEFAULT_SUBSCRIBERS.dup
       end
 

sentry-rails/lib/sentry/rails/log_subscribers/action_controller_subscriber.rb

@@ -15,7 +15,6 @@ module LogSubscribers
       # @example Usage
       #   # Enable structured logging for ActionController
       #   Sentry.init do |config|
-      #     config.enable_logs = true
       #     config.rails.structured_logging = true
       #     config.rails.structured_logging.subscribers = { action_controller: Sentry::Rails::LogSubscribers::ActionControllerSubscriber }
       #   end

sentry-rails/lib/sentry/rails/log_subscribers/action_mailer_subscriber.rb

@@ -14,7 +14,6 @@ module LogSubscribers
       # @example Usage
       #   # Enable structured logging for ActionMailer
       #   Sentry.init do |config|
-      #     config.enable_logs = true
       #     config.rails.structured_logging = true
       #     config.rails.structured_logging.subscribers = { action_mailer: Sentry::Rails::LogSubscribers::ActionMailerSubscriber }
       #   end

sentry-rails/lib/sentry/rails/log_subscribers/active_job_subscriber.rb

@@ -14,7 +14,6 @@ module LogSubscribers
       # @example Usage
       #   # Enable structured logging for ActiveJob
       #   Sentry.init do |config|
-      #     config.enable_logs = true
       #     config.rails.structured_logging = true
       #     config.rails.structured_logging.subscribers = { active_job: Sentry::Rails::LogSubscribers::ActiveJobSubscriber }
       #   end

sentry-rails/lib/sentry/rails/log_subscribers/active_record_subscriber.rb

@@ -15,7 +15,6 @@ module LogSubscribers
       # @example Usage
       #   # Automatically attached when structured logging is enabled for :active_record
       #   Sentry.init do |config|
-      #     config.enable_logs = true
       #     config.rails.structured_logging = true
       #     config.rails.structured_logging.subscribers = { active_record: Sentry::Rails::LogSubscribers::ActiveRecordSubscriber }
       #   end

sentry-rails/lib/sentry/rails/railtie.rb

@@ -142,7 +142,7 @@ def activate_tracing
     end
 
     def activate_structured_logging
-      if Sentry.configuration.rails.structured_logging.enabled? && Sentry.configuration.enable_logs
+      if Sentry.configuration.rails.structured_logging.enabled?
         Sentry::Rails::StructuredLogging.attach(Sentry.configuration.rails.structured_logging)
       end
     end

sentry-rails/spec/active_job/shared_examples/structured_logging.rb

@@ -3,7 +3,6 @@
 RSpec.shared_examples "an ActiveJob backend that produces structured logs" do
   let(:configure_sentry) do
     proc do |config, _app|
-      config.enable_logs = true
       config.rails.structured_logging.enabled = true
       config.rails.structured_logging.subscribers = {
         active_job: Sentry::Rails::LogSubscribers::ActiveJobSubscriber

sentry-rails/spec/active_job/shared_examples/tracing/user_propagation.rb

@@ -63,7 +63,6 @@
       proc do |config|
         config.traces_sample_rate = 1.0
         config.send_default_pii = true
-        config.enable_logs = true
       end
     end
 

sentry-rails/spec/active_job/support/harness.rb

@@ -73,7 +73,7 @@ def perform(*_args, **_kwargs)
       Sentry::Rails::Tracing.patch_active_support_notifications
     end
 
-    if Sentry.configuration.rails.structured_logging.enabled? && Sentry.configuration.enable_logs
+    if Sentry.configuration.rails.structured_logging.enabled?
       Sentry::Rails::StructuredLogging.attach(Sentry.configuration.rails.structured_logging)
     end
 

sentry-rails/spec/isolated/rails_logger_patch_spec.rb

@@ -10,7 +10,6 @@
   context "when :logger patch is enabled" do
     before do
       make_basic_app do |config, app|
-        config.enable_logs = true
         config.enabled_patches = [:logger]
         config.max_log_events = 10
         config.sdk_logger = Logger.new(nil)
@@ -202,7 +201,6 @@
     let(:broadcast_logger) { ActiveSupport::BroadcastLogger.new(logger1, logger2) }
     let(:broadcast_app) do
       make_basic_app do |config|
-        config.enable_logs = true
         config.enabled_patches = [:logger]
         config.max_log_events = 10
         config.sdk_logger = Logger.new(nil)