From f288111ba40237f3b3a1998d03b52ea129c7816f Mon Sep 17 00:00:00 2001 From: JPeer264 Date: Wed, 21 Oct 2026 15:27:49 +0200 Subject: [PATCH] chore(bugbot): Flag new Cloudflare tests that wrap the worker by hand New Cloudflare integration test suites, E2E apps and Cloudflare variants of existing E2E apps should use the Sentry Cloudflare Vite plugin with an instrument.server.ts, not withSentry or the instrument*WithSentry helpers. Tests of these wrappers and apps that do not build with Vite are exempt. Co-Authored-By: Claude Opus 5.5 --- .cursor/BUGBOT.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.cursor/BUGBOT.md b/.cursor/BUGBOT.md index a394e1130d84..8212b1b8489e 100644 --- a/.cursor/BUGBOT.md +++ b/.cursor/BUGBOT.md @@ -101,6 +101,7 @@ Keep reviews high-signal. Prefer actionable, high-confidence findings over specu - Timeouts or sleeps in tests. Instead suggest concrete events or other signals to wait on. - Flag usage of `getFirstEnvelope*`, `getMultipleEnvelope*` or related test helpers in E2E tests. These are NOT reliable anymore. Instead suggest helpers like `waitForTransaction`, `waitForError`, `waitForSpans`, etc. - Flag any new or modified `docker-compose.yml` under `dev-packages/node-integration-tests/suites/` where a service does not define a `healthcheck:`. The runner uses `docker compose up --wait` and relies on healthchecks to know when services are actually ready; without one the test will race the service's startup. +- Flag new Cloudflare tests that wrap the worker by hand with `withSentry`, `instrumentDurableObjectWithSentry`, `instrumentAgentWithSentry` or `instrumentWorkflowWithSentry`. This covers new suites under `dev-packages/cloudflare-integration-tests/suites/`, new E2E apps under `dev-packages/e2e-tests/test-applications/` that run on Cloudflare, and new Cloudflare variants of existing E2E apps (an entry in `sentryTest.variants` of the app's `package.json`, for example `hono-4 (cloudflare)`). App names do not always start with `cloudflare-`. Recommend the Sentry Cloudflare Vite plugin instead: `plugins: [cloudflare(), sentryCloudflareVitePlugin()]` in `vite.config.*` (`sentryCloudflareVitePlugin` from `@sentry/cloudflare/vite`), and the SDK options in an `instrument.server.ts` next to the worker entry that default-exports `defineCloudflareOptions(...)`. Do not flag tests whose purpose is to test one of these wrappers, or apps that do not build with Vite (for example Next.js on OpenNext). ## Platform-safe code