From 01457db4be14ecbab5ef2fbc3a7331f80311b07b Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Thu, 15 Oct 2026 13:48:36 +0200 Subject: [PATCH] test(e2e): Remove event dumps and their normalization script The Next.js apps dumped all envelopes to `event-dumps/`, which CI uploaded on failure after normalizing transactions into span trees. The normalization has not found any dumps since E2E apps moved to a temp directory, and it doesn't understand streamed spans. Nobody relies on the dumps, so drop the feature. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/build.yml | 30 ----- dev-packages/e2e-tests/package.json | 2 +- .../cloudflare-think/start-event-proxy.mjs | 1 - .../test-applications/nextjs-14/.gitignore | 1 - .../nextjs-14/start-event-proxy.mjs | 8 -- .../nextjs-15-basepath/.gitignore | 1 - .../nextjs-15-basepath/start-event-proxy.mjs | 8 -- .../nextjs-15-intl/.gitignore | 1 - .../nextjs-15-intl/start-event-proxy.mjs | 8 -- .../test-applications/nextjs-15/.gitignore | 1 - .../nextjs-15/start-event-proxy.mjs | 8 -- .../start-event-proxy.mjs | 8 -- .../nextjs-16-standalone/.gitignore | 2 - .../start-event-proxy.mjs | 8 -- .../nextjs-16-static/start-event-proxy.mjs | 8 -- .../start-event-proxy.mjs | 8 -- .../nextjs-16-streaming/start-event-proxy.mjs | 8 -- .../start-event-proxy.mjs | 8 -- .../start-event-proxy.mjs | 8 -- .../nextjs-16-tunnel/.gitignore | 2 - .../nextjs-16-tunnel/start-event-proxy.mjs | 8 -- .../nextjs-16-userfeedback/.gitignore | 1 - .../start-event-proxy.mjs | 8 -- .../nextjs-16/start-event-proxy.mjs | 8 -- .../nextjs-app-dir/.gitignore | 1 - .../nextjs-app-dir/start-event-proxy.mjs | 8 -- .../test-applications/nextjs-otlp/.gitignore | 2 - .../nextjs-pages-dir/.gitignore | 1 - .../nextjs-pages-dir/start-event-proxy.mjs | 8 -- .../test-utils/src/event-proxy-server.ts | 15 --- ...malize-e2e-test-dump-transaction-events.js | 121 ------------------ 31 files changed, 1 insertion(+), 309 deletions(-) delete mode 100644 scripts/normalize-e2e-test-dump-transaction-events.js diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 81d5b1882f17..3437a52ebc40 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1174,21 +1174,6 @@ jobs: overwrite: true retention-days: 7 - - name: Pre-process E2E Test Dumps - if: failure() - run: | - node ./scripts/normalize-e2e-test-dump-transaction-events.js ${{ runner.temp }}/test-application/event-dumps - - - name: Upload E2E Test Event Dumps - uses: actions/upload-artifact@v7 - if: failure() - with: - name: E2E Test Dump (${{ matrix.label || matrix.test-application }}) - path: ${{ runner.temp }}/test-application/event-dumps - overwrite: true - retention-days: 7 - if-no-files-found: ignore - # - We skip optional tests on release branches job_optional_e2e_tests: name: E2E ${{ matrix.label || matrix.test-application }} Test (optional) @@ -1302,21 +1287,6 @@ jobs: timeout-minutes: 10 run: ${{ matrix.assert-command || 'pnpm test:assert' }} - - name: Pre-process E2E Test Dumps - if: failure() - run: | - node ./scripts/normalize-e2e-test-dump-transaction-events.js ${{ runner.temp }}/test-application/event-dumps - - - name: Upload E2E Test Event Dumps - uses: actions/upload-artifact@v7 - if: failure() - with: - name: E2E Test Dump (${{ matrix.label || matrix.test-application }}) - path: ${{ runner.temp }}/test-application/event-dumps - overwrite: true - retention-days: 7 - if-no-files-found: ignore - job_required_jobs_passed: name: All required jobs passed or were skipped needs: diff --git a/dev-packages/e2e-tests/package.json b/dev-packages/e2e-tests/package.json index 7abbb49fd143..976df6f40e7a 100644 --- a/dev-packages/e2e-tests/package.json +++ b/dev-packages/e2e-tests/package.json @@ -15,7 +15,7 @@ "ci:build-matrix-optional": "node ./lib/getTestMatrix.mjs --optional=true", "ci:copy-to-temp": "node ./ciCopyToTemp.mjs", "ci:pnpm-overrides": "node ./ciPnpmOverrides.mjs", - "clean:test-applications": "rimraf --glob test-applications/**/{node_modules,dist,build,.next,.nuxt,.sveltekit,.react-router,.astro,.output,pnpm-lock.yaml,.last-run.json,test-results,.angular,event-dumps}", + "clean:test-applications": "rimraf --glob test-applications/**/{node_modules,dist,build,.next,.nuxt,.sveltekit,.react-router,.astro,.output,pnpm-lock.yaml,.last-run.json,test-results,.angular}", "clean:pnpm": "pnpm store prune" }, "devDependencies": { diff --git a/dev-packages/e2e-tests/test-applications/cloudflare-think/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/cloudflare-think/start-event-proxy.mjs index 784fc99f86ba..bfb72c474641 100644 --- a/dev-packages/e2e-tests/test-applications/cloudflare-think/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/cloudflare-think/start-event-proxy.mjs @@ -3,5 +3,4 @@ import { startEventProxyServer } from '@sentry-internal/test-utils'; startEventProxyServer({ port: 3031, proxyServerName: 'cloudflare-think', - envelopeDumpPath: process.env.SENTRY_ENVELOPE_DUMP_PATH, }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-14/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-14/.gitignore index ebdbfc025b6a..e799cc33c4e7 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-14/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-14/.gitignore @@ -43,4 +43,3 @@ next-env.d.ts .vscode test-results -event-dumps diff --git a/dev-packages/e2e-tests/test-applications/nextjs-14/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-14/start-event-proxy.mjs index 7e0ebce43981..39babfb19b2a 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-14/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-14/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-14', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-14-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-15-basepath/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-15-basepath/.gitignore index 0c60c8eeaee8..45459b9b7857 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-15-basepath/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-15-basepath/.gitignore @@ -43,6 +43,5 @@ next-env.d.ts .vscode test-results -event-dumps .tmp_dev_server_logs diff --git a/dev-packages/e2e-tests/test-applications/nextjs-15-basepath/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-15-basepath/start-event-proxy.mjs index e8834a451788..2a1973be5e1f 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-15-basepath/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-15-basepath/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-15-basepath', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-15-basepath-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-15-intl/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-15-intl/.gitignore index 2d0dd371dc86..9846ac311254 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-15-intl/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-15-intl/.gitignore @@ -46,6 +46,5 @@ pnpm-lock.yaml .tmp_dev_server_logs .tmp_build_stdout .tmp_build_stderr -event-dumps test-results diff --git a/dev-packages/e2e-tests/test-applications/nextjs-15-intl/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-15-intl/start-event-proxy.mjs index 8f6b9b5886d5..dc5f94bbfef5 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-15-intl/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-15-intl/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-15-intl', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/nextjs-15-intl-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-15/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-15/.gitignore index 0c60c8eeaee8..45459b9b7857 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-15/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-15/.gitignore @@ -43,6 +43,5 @@ next-env.d.ts .vscode test-results -event-dumps .tmp_dev_server_logs diff --git a/dev-packages/e2e-tests/test-applications/nextjs-15/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-15/start-event-proxy.mjs index d78a76402bbb..90d736790faa 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-15/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-15/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-15', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-15-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-cacheComponents/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16-cacheComponents/start-event-proxy.mjs index f0fae444f2eb..dff27c745a56 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-cacheComponents/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-cacheComponents/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16-cacheComponents', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-16-cacheComponents-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-standalone/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-16-standalone/.gitignore index ae044ec5ad53..dd146b53d966 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-standalone/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-standalone/.gitignore @@ -10,8 +10,6 @@ !.yarn/releases !.yarn/versions -event-dumps - # testing /coverage diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-standalone/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16-standalone/start-event-proxy.mjs index 89c563e70477..700fdc3e6c25 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-standalone/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-standalone/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16-standalone', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/nextjs-16-standalone-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-static/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16-static/start-event-proxy.mjs index c13c32c146e5..dd51d61d7941 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-static/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-static/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16-static', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-16-static-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-streaming-cacheComponents/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16-streaming-cacheComponents/start-event-proxy.mjs index 493d4fff94fe..3ea01598c055 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-streaming-cacheComponents/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-streaming-cacheComponents/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16-streaming-cacheComponents', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-16-cacheComponents-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-streaming/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16-streaming/start-event-proxy.mjs index 9b3556d402af..ddc4e91352a8 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-streaming/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-streaming/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16-streaming', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-16-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-trailing-slash-static/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16-trailing-slash-static/start-event-proxy.mjs index 5ff551125b03..ee4744f98f51 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-trailing-slash-static/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-trailing-slash-static/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16-trailing-slash-static', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-16-trailing-slash-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-trailing-slash/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16-trailing-slash/start-event-proxy.mjs index 31efe3256f8b..dae15c70737f 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-trailing-slash/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-trailing-slash/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16-trailing-slash', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-16-trailing-slash-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-tunnel/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-16-tunnel/.gitignore index ae044ec5ad53..dd146b53d966 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-tunnel/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-tunnel/.gitignore @@ -10,8 +10,6 @@ !.yarn/releases !.yarn/versions -event-dumps - # testing /coverage diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-tunnel/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16-tunnel/start-event-proxy.mjs index 976073d3d2c4..ed2642708c9c 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-tunnel/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-tunnel/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16-tunnel', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/nextjs-16-tunnel-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/.gitignore index 0c60c8eeaee8..45459b9b7857 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/.gitignore @@ -43,6 +43,5 @@ next-env.d.ts .vscode test-results -event-dumps .tmp_dev_server_logs diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/start-event-proxy.mjs index c7aebbaee27a..18aa90f97fb4 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16-userfeedback', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/nextjs-16-userfeedback-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-16/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-16/start-event-proxy.mjs index 572631b890ed..1053e3049c31 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-16/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-16/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-16', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-16-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-app-dir/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-app-dir/.gitignore index ebdbfc025b6a..e799cc33c4e7 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-app-dir/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-app-dir/.gitignore @@ -43,4 +43,3 @@ next-env.d.ts .vscode test-results -event-dumps diff --git a/dev-packages/e2e-tests/test-applications/nextjs-app-dir/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-app-dir/start-event-proxy.mjs index c243a72b8f07..7e8016bf98a5 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-app-dir/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-app-dir/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-app-dir', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-app-dir-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-otlp/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-otlp/.gitignore index ae044ec5ad53..dd146b53d966 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-otlp/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-otlp/.gitignore @@ -10,8 +10,6 @@ !.yarn/releases !.yarn/versions -event-dumps - # testing /coverage diff --git a/dev-packages/e2e-tests/test-applications/nextjs-pages-dir/.gitignore b/dev-packages/e2e-tests/test-applications/nextjs-pages-dir/.gitignore index ebdbfc025b6a..e799cc33c4e7 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-pages-dir/.gitignore +++ b/dev-packages/e2e-tests/test-applications/nextjs-pages-dir/.gitignore @@ -43,4 +43,3 @@ next-env.d.ts .vscode test-results -event-dumps diff --git a/dev-packages/e2e-tests/test-applications/nextjs-pages-dir/start-event-proxy.mjs b/dev-packages/e2e-tests/test-applications/nextjs-pages-dir/start-event-proxy.mjs index 00d301804ba1..b7a948213713 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-pages-dir/start-event-proxy.mjs +++ b/dev-packages/e2e-tests/test-applications/nextjs-pages-dir/start-event-proxy.mjs @@ -1,14 +1,6 @@ -import * as fs from 'fs'; -import * as path from 'path'; import { startEventProxyServer } from '@sentry-internal/test-utils'; -const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))); - startEventProxyServer({ port: 3031, proxyServerName: 'nextjs-pages-dir', - envelopeDumpPath: path.join( - process.cwd(), - `event-dumps/next-pages-dir-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`, - ), }); diff --git a/dev-packages/test-utils/src/event-proxy-server.ts b/dev-packages/test-utils/src/event-proxy-server.ts index 627b3995ba05..ae3aea0ff297 100644 --- a/dev-packages/test-utils/src/event-proxy-server.ts +++ b/dev-packages/test-utils/src/event-proxy-server.ts @@ -26,8 +26,6 @@ interface EventProxyServerOptions { port: number; /** The name for the proxy server used for referencing it with listener functions */ proxyServerName: string; - /** A path to optionally output all Envelopes to. Can be used to compare event payloads before and after changes. */ - envelopeDumpPath?: string; } interface SentryRequestCallbackData { @@ -179,15 +177,6 @@ export async function startProxyServer( * option to this server (like this `tunnel: http://localhost:${port option}/`). */ export async function startEventProxyServer(options: EventProxyServerOptions): Promise { - if (options.envelopeDumpPath) { - await fs.promises.mkdir(path.dirname(path.resolve(options.envelopeDumpPath)), { recursive: true }); - try { - await fs.promises.unlink(path.resolve(options.envelopeDumpPath)); - } catch { - // noop - } - } - await startProxyServer(options, async (eventCallbackListeners, proxyRequest, proxyRequestBody, eventBuffer) => { const data: SentryRequestCallbackData = { envelope: parseEnvelope(proxyRequestBody), @@ -205,10 +194,6 @@ export async function startEventProxyServer(options: EventProxyServerOptions): P listener(dataString); }); - if (options.envelopeDumpPath) { - fs.appendFileSync(path.resolve(options.envelopeDumpPath), `${JSON.stringify(data.envelope)}\n`, 'utf-8'); - } - return [ 200, '{}', diff --git a/scripts/normalize-e2e-test-dump-transaction-events.js b/scripts/normalize-e2e-test-dump-transaction-events.js deleted file mode 100644 index 376b86d2b413..000000000000 --- a/scripts/normalize-e2e-test-dump-transaction-events.js +++ /dev/null @@ -1,121 +0,0 @@ -// @ts-check -/* eslint-disable no-console */ - -const fs = require('fs'); -const path = require('path'); - -const dumpDir = process.argv[2]; -if (!dumpDir) { - throw new Error('Usage: node normalize-e2e-test-dump-transaction-events.js '); -} - -const dumpPaths = fs.existsSync(dumpDir) - ? fs - .readdirSync(dumpDir) - .filter(name => name.endsWith('.dump')) - .map(name => path.join(dumpDir, name)) - : []; - -dumpPaths.forEach(dumpPath => { - const fileContents = fs.readFileSync(dumpPath, 'utf8'); - - const transactionNodes = []; - - fileContents.split('\n').forEach(serializedEnvelope => { - let envelope; - try { - envelope = JSON.parse(serializedEnvelope); - } catch { - return; - // noop - } - - const envelopeItems = envelope[1]; - - envelopeItems.forEach(([envelopeItemHeader, transaction]) => { - if (envelopeItemHeader.type === 'transaction') { - const rootNode = { - runtime: transaction.contexts.runtime?.name, - op: transaction.contexts.trace.op, - name: transaction.transaction, - children: [], - }; - - const spanMap = new Map(); - spanMap.set(transaction.contexts.trace.span_id, rootNode); - - transaction.spans.forEach(span => { - const node = { - op: span.data['sentry.op'], - name: span.description, - parent_span_id: span.parent_span_id, - children: [], - }; - spanMap.set(span.span_id, node); - }); - - transaction.spans.forEach(span => { - const node = spanMap.get(span.span_id); - if (node?.parent_span_id) { - const parentNode = spanMap.get(node.parent_span_id); - parentNode.children.push(node); - } - }); - - transactionNodes.push(rootNode); - } - }); - }); - - const output = transactionNodes - .sort((a, b) => { - const aSerialized = serializeNode(a); - const bSerialized = serializeNode(b); - if (aSerialized < bSerialized) { - return -1; - } else if (aSerialized > bSerialized) { - return 1; - } else { - return 0; - } - }) - .map(node => buildDeterministicStringFromNode(node)) - .join('\n\n-----------------------\n\n'); - - fs.writeFileSync( - path.join(path.dirname(dumpPath), `normalized-transactions-${path.basename(dumpPath, '.dump')}.txt`), - output, - 'utf-8', - ); -}); - -// ------- utility fns ---------- - -function buildDeterministicStringFromNode(node, depth = 0) { - const mainParts = []; - if (node.runtime) { - mainParts.push(`(${node.runtime})`); - } - mainParts.push(`${node.op ?? 'default'} -`); - mainParts.push(node.name); - const main = mainParts.join(' '); - const children = node.children - .sort((a, b) => { - const aSerialized = serializeNode(a); - const bSerialized = serializeNode(b); - if (aSerialized < bSerialized) { - return -1; - } else if (aSerialized > bSerialized) { - return 1; - } else { - return 0; - } - }) - .map(child => '\n' + buildDeterministicStringFromNode(child, depth + 1)) - .join(''); - return `${main}${children}`.split('\n').join('\n '); -} - -function serializeNode(node) { - return [node.op, node.name, node.runtime].join('---'); -}