Skip to content

Commit cda6116

Browse files
nicohrubeccodex
andcommitted
ci: try six workers across Playwright suites
Restore serial browser bundling and retain three Node integration shards. Co-Authored-By: GPT-6 <codex@openai.com>
1 parent 7080ca9 commit cda6116

11 files changed

Lines changed: 10 additions & 28 deletions

File tree

‎dev-packages/browser-integration-tests/playwright.browser.config.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import CorePlaywrightConfig from './playwright.config';
33

44
const config: PlaywrightTestConfig = {
55
...CorePlaywrightConfig,
6-
workers: process.env.CI ? 6 : CorePlaywrightConfig.workers,
76
testDir: './suites',
87
};
98

‎dev-packages/browser-integration-tests/playwright.config.ts‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ const config: PlaywrightTestConfig = {
55
retries: 0,
66
// Run tests inside of a single file in parallel
77
fullyParallel: true,
8-
// Use 3 workers on CI, else use defaults (based on available CPU cores)
9-
// Note that 3 is a random number selected to work well with our CI setup
10-
workers: process.env.CI ? 3 : undefined,
8+
workers: process.env.CI ? 6 : undefined,
119
testMatch: /test.ts/,
1210

1311
use: {

‎dev-packages/e2e-tests/test-applications/cloudflare-workers-send-to-sentry/playwright.config.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export default defineConfig({
1010
fullyParallel: true,
1111
forbidOnly: !!process.env.CI,
1212
retries: 0,
13-
// Every test spends most of its time polling Sentry, so run them all at once.
14-
workers: '100%',
13+
workers: process.env.CI ? 6 : '100%',
1514
reporter: process.env.CI ? [['list'], ['junit', { outputFile: 'results.junit.xml' }]] : 'list',
1615
});

‎dev-packages/e2e-tests/test-applications/ember-classic/playwright.config.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const config: PlaywrightTestConfig = {
3030
timeout: 10000,
3131
},
3232
fullyParallel: false,
33-
workers: 1,
33+
workers: process.env.CI ? 6 : 1,
3434
/* Fail the build on CI if you accidentally left test.only in the source code. */
3535
forbidOnly: !!process.env.CI,
3636
retries: 0,

‎dev-packages/e2e-tests/test-applications/ember-embroider/playwright.config.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const config: PlaywrightTestConfig = {
3030
timeout: 10000,
3131
},
3232
fullyParallel: false,
33-
workers: 1,
33+
workers: process.env.CI ? 6 : 1,
3434
/* Fail the build on CI if you accidentally left test.only in the source code. */
3535
forbidOnly: !!process.env.CI,
3636
retries: 0,

‎dev-packages/e2e-tests/test-applications/node-express-send-to-sentry-static/playwright.config.mjs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ const config = {
1818
},
1919
/* Run tests in files in parallel */
2020
fullyParallel: true,
21+
workers: process.env.CI ? 6 : undefined,
2122
/* Fail the build on CI if you accidentally left test.only in the source code. */
2223
forbidOnly: !!process.env.CI,
2324
/* Retry on CI only */

‎dev-packages/e2e-tests/test-applications/node-express-send-to-sentry/playwright.config.mjs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ const config = {
1818
},
1919
/* Run tests in files in parallel */
2020
fullyParallel: true,
21+
workers: process.env.CI ? 6 : undefined,
2122
/* Fail the build on CI if you accidentally left test.only in the source code. */
2223
forbidOnly: !!process.env.CI,
2324
/* Retry on CI only */

‎dev-packages/e2e-tests/test-applications/react-send-to-sentry/playwright.config.mjs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ const config = {
2020
forbidOnly: !!process.env.CI,
2121
/* Retry on CI only */
2222
retries: 0,
23-
/* Opt out of parallel tests on CI. */
24-
workers: 1,
23+
workers: process.env.CI ? 6 : 1,
2524
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
2625
reporter: process.env.CI ? [['list'], ['junit', { outputFile: 'results.junit.xml' }]] : 'list',
2726
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */

‎dev-packages/test-utils/src/playwright-config.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export function getPlaywrightConfig(
3131
timeout: 10000,
3232
},
3333
fullyParallel: false,
34-
workers: 1,
3534
/* Fail the build on CI if you accidentally left test.only in the source code. */
3635
forbidOnly: !!process.env.CI,
3736
/* In dev mode some apps are flaky, so we allow retry there... */
@@ -96,5 +95,6 @@ export function getPlaywrightConfig(
9695
return {
9796
...config,
9897
...overwriteConfig,
98+
workers: process.env.CI ? 6 : (overwriteConfig?.workers ?? 1),
9999
};
100100
}

‎packages/browser/package.json‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,7 @@
5252
"scripts": {
5353
"build": "run-p build:transpile build:bundle build:types",
5454
"build:dev": "run-p build:transpile build:types",
55-
"build:bundle": "run-p build:bundle:shard:*",
56-
"build:bundle:shard:1": "rollup -c rollup.bundle.config.mjs --configShard=1",
57-
"build:bundle:shard:2": "rollup -c rollup.bundle.config.mjs --configShard=2",
58-
"build:bundle:shard:3": "rollup -c rollup.bundle.config.mjs --configShard=3",
55+
"build:bundle": "rollup -c rollup.bundle.config.mjs",
5956
"build:transpile": "rollup -c rollup.npm.config.mjs",
6057
"build:types": "tsc -p tsconfig.types.json",
6158
"build:watch": "run-p build:transpile:watch build:bundle:watch",

0 commit comments

Comments
 (0)