Use separate instrument files for disabled recording

Author: andreiborza

dev-packages/node-integration-tests/suites/tracing/typesafe/instrument-manual-no-recording.mjs

@@ -0,0 +1,13 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  release: '1.0',
+  tracesSampleRate: 1.0,
+  transport: loggingTransport,
+  dataCollection: { genAI: { inputs: false, outputs: false } },
+  // `instrumentTypeSafeClient` is the manual path for runtimes without the orchestrion hook.
+  // Drop the automatic integration so the scenario exercises it alone.
+  integrations: integrations => integrations.filter(integration => integration.name !== 'TypeSafe'),
+});

dev-packages/node-integration-tests/suites/tracing/typesafe/instrument-manual.mjs

@@ -6,8 +6,6 @@ Sentry.init({
   release: '1.0',
   tracesSampleRate: 1.0,
   transport: loggingTransport,
-  // `NO_RECORDING` turns off recording of inputs and outputs for the privacy test.
-  ...(process.env.NO_RECORDING ? { dataCollection: { genAI: { inputs: false, outputs: false } } } : {}),
   // `instrumentTypeSafeClient` is the manual path for runtimes without the orchestrion hook.
   // Drop the automatic integration so the scenario exercises it alone.
   integrations: integrations => integrations.filter(integration => integration.name !== 'TypeSafe'),

dev-packages/node-integration-tests/suites/tracing/typesafe/instrument-no-recording.mjs

@@ -0,0 +1,10 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  release: '1.0',
+  tracesSampleRate: 1.0,
+  transport: loggingTransport,
+  dataCollection: { genAI: { inputs: false, outputs: false } },
+});

dev-packages/node-integration-tests/suites/tracing/typesafe/instrument.mjs

@@ -6,6 +6,4 @@ Sentry.init({
   release: '1.0',
   tracesSampleRate: 1.0,
   transport: loggingTransport,
-  // `NO_RECORDING` turns off recording of inputs and outputs for the privacy test.
-  ...(process.env.NO_RECORDING ? { dataCollection: { genAI: { inputs: false, outputs: false } } } : {}),
 });

dev-packages/node-integration-tests/suites/tracing/typesafe/test.ts

@@ -20,9 +20,9 @@ describe('TypeSafe integration', () => {
   });
 
   describe.each([
-    ['automatic', 'instrument.mjs'],
-    ['manual', 'instrument-manual.mjs'],
-  ])('%s instrumentation', (_, instrumentFile) => {
+    ['automatic', 'instrument.mjs', 'instrument-no-recording.mjs'],
+    ['manual', 'instrument-manual.mjs', 'instrument-manual-no-recording.mjs'],
+  ])('%s instrumentation', (_, instrumentFile, noRecordingInstrumentFile) => {
     createEsmAndCjsTests(
       __dirname,
       'scenario.mjs',
@@ -112,10 +112,21 @@ describe('TypeSafe integration', () => {
             .start()
             .completed();
         });
+      },
+      {
+        additionalDependencies: {
+          '@typesafe-ai/sdk': '^0.6.0',
+        },
+      },
+    );
 
+    createEsmAndCjsTests(
+      __dirname,
+      'scenario.mjs',
+      noRecordingInstrumentFile,
+      (createRunner, test) => {
         test('does not record inputs or outputs when recording is off', async () => {
           await createRunner()
-            .withEnv({ NO_RECORDING: 'true' })
             .unordered()
             .expect({
               span: container => {