Skip to content

Commit 68b6f79

Browse files
Lms24claude
andauthored
chore(solidstart): Remove unused Vitest setup from e2e apps (#24789)
The SolidStart e2e apps only run Playwright, so `vitest`, `@vitest/ui` and `vitest.config.ts` are unused leftovers from the Solid CLI template. Noticed while working on #24746. Didn't cause a direct dependency duplication but thought it would be good to get this cleaned up. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent aedd977 commit 68b6f79

24 files changed

Lines changed: 12 additions & 145 deletions

File tree

‎dev-packages/e2e-tests/test-applications/solidstart-2/README.md‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment
3131
By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add
3232
it to the `devDependencies` in `package.json` and specify in your `app.config.js`.
3333

34-
## Testing
35-
36-
Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some
37-
helpful custom matchers.
38-
39-
To run them, simply start:
40-
41-
```sh
42-
npm test
43-
```
44-
4534
## This project was created with the [Solid CLI](https://solid-cli.netlify.app)

‎dev-packages/e2e-tests/test-applications/solidstart-2/package.json‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,11 @@
2525
"@solidjs/testing-library": "^0.8.10",
2626
"@testing-library/jest-dom": "^6.4.2",
2727
"@testing-library/user-event": "^14.5.2",
28-
"@vitest/ui": "^1.5.0",
2928
"jsdom": "^24.0.0",
3029
"solid-js": "1.9.14",
3130
"typescript": "^5.4.5",
3231
"vite": "^8.1.5",
33-
"vite-plugin-solid": "^2.11.6",
34-
"vitest": "^1.5.0"
32+
"vite-plugin-solid": "^2.11.6"
3533
},
3634
"volta": {
3735
"extends": "../../package.json"

‎dev-packages/e2e-tests/test-applications/solidstart-2/tsconfig.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"allowJs": true,
1111
"strict": true,
1212
"noEmit": true,
13-
"types": ["@solidjs/start/env", "vitest/globals", "@testing-library/jest-dom"],
13+
"types": ["@solidjs/start/env", "@testing-library/jest-dom"],
1414
"isolatedModules": true,
1515
"paths": {
1616
"~/*": ["./src/*"]

‎dev-packages/e2e-tests/test-applications/solidstart-2/vitest.config.ts‎

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/README.md‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment
3131
By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add
3232
it to the `devDependencies` in `package.json` and specify in your `app.config.js`.
3333

34-
## Testing
35-
36-
Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some
37-
helpful custom matchers.
38-
39-
To run them, simply start:
40-
41-
```sh
42-
npm test
43-
```
44-
4534
## This project was created with the [Solid CLI](https://solid-cli.netlify.app)

‎dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
"typescript": "^5.4.5",
2929
"vinxi": "^0.4.0",
3030
"vite": "^5.4.10",
31-
"vite-plugin-solid": "^2.11.6",
32-
"vitest": "^3.2.7"
31+
"vite-plugin-solid": "^2.11.6"
3332
},
3433
"volta": {
3534
"extends": "../../package.json"

‎dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tsconfig.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"allowJs": true,
1111
"strict": true,
1212
"noEmit": true,
13-
"types": ["vinxi/types/client", "vitest/globals", "@testing-library/jest-dom"],
13+
"types": ["vinxi/types/client", "@testing-library/jest-dom"],
1414
"isolatedModules": true,
1515
"paths": {
1616
"~/*": ["./src/*"]

‎dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/vitest.config.ts‎

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎dev-packages/e2e-tests/test-applications/solidstart-spa/README.md‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment
3131
By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add
3232
it to the `devDependencies` in `package.json` and specify in your `app.config.js`.
3333

34-
## Testing
35-
36-
Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some
37-
helpful custom matchers.
38-
39-
To run them, simply start:
40-
41-
```sh
42-
npm test
43-
```
44-
4534
## This project was created with the [Solid CLI](https://solid-cli.netlify.app)

‎dev-packages/e2e-tests/test-applications/solidstart-spa/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
"typescript": "^5.4.5",
2929
"vinxi": "^0.4.0",
3030
"vite": "^5.4.11",
31-
"vite-plugin-solid": "^2.11.6",
32-
"vitest": "^3.2.7"
31+
"vite-plugin-solid": "^2.11.6"
3332
},
3433
"volta": {
3534
"extends": "../../package.json"

0 commit comments

Comments
 (0)