Skip to content

Commit 3ab242c

Browse files
JPeer264claude
andcommitted
chore: Declare workspace packages where they are imported
The root package.json listed every workspace package as a `workspace:*` devDependency, so that each package could import any of them from the root node_modules folder like with Yarn. Remove these entries and declare the workspace packages in the packages that import them, for example `@sentry-internal/rollup-utils` in the rollup configs. The root keeps three of them: - `@sentry-internal/node-integration-tests`, because its suites import it by its own name, also from tmp folders that have their own package.json. - `@sentry/eslint-plugin-sdk`, because the root oxlint config loads it as a JS plugin. - `@sentry/sveltekit`, because size-limit bundles its build output, which imports `@sentry/sveltekit/browser-tracing-variant`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 86310e6 commit 3ab242c

49 files changed

Lines changed: 264 additions & 240 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎dev-packages/browser-integration-tests/package.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,11 @@
7272
"webpack": "^5.95.0"
7373
},
7474
"devDependencies": {
75+
"@sentry/browser-utils": "11.8.0",
76+
"@sentry/core": "11.8.0",
77+
"@sentry/replay-canvas": "11.8.0",
7578
"@sentry/rrweb-types": "^2.44.1",
79+
"@sentry/wasm": "11.8.0",
7680
"@types/node": "^18.19.1",
7781
"eslint-plugin-regexp": "^3.1.0",
7882
"glob": "^13.0.6"

‎dev-packages/bun-integration-tests/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"devDependencies": {
2424
"@sentry-internal/node-integration-tests": "11.8.0",
2525
"@sentry-internal/test-utils": "11.8.0",
26+
"@sentry/core": "11.8.0",
2627
"@types/mysql": "^2.15.27",
2728
"@types/pg": "^8.20.0",
2829
"bun-types": "^1.2.9",

‎dev-packages/node-integration-tests/package.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
"@sentry/core": "11.8.0",
5757
"@sentry/hono": "11.8.0",
5858
"@sentry/node": "11.8.0",
59+
"@sentry/server-runtime-injection": "11.8.0",
5960
"@sentry/server-utils": "11.8.0",
6061
"@smithy/node-http-handler": "4.12.1",
6162
"@types/mongodb": "^3.6.20",
@@ -113,8 +114,10 @@
113114
"@hapi/boom": "^10.0.1",
114115
"@neondatabase/serverless": "1.2.0",
115116
"@opentelemetry/instrumentation-http": "0.220.0",
117+
"@sentry-internal/rollup-utils": "11.8.0",
116118
"@sentry/conventions": "0.27.0",
117119
"@sentry-internal/test-utils": "11.8.0",
120+
"@sentry/node-native": "11.8.0",
118121
"@types/amqplib": "^0.10.5",
119122
"@types/express": "^4.17.21",
120123
"@types/node-cron": "^3.0.11",

‎dev-packages/test-utils/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
},
6969
"devDependencies": {
7070
"@playwright/test": "~1.63.0",
71+
"@sentry-internal/rollup-utils": "11.8.0",
7172
"@sentry/core": "11.8.0",
7273
"@types/express": "^4.17.21",
7374
"@types/ws": "^8.18.1",

‎package.json‎

Lines changed: 3 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -122,78 +122,19 @@
122122
"dev-packages/bundler-tests"
123123
],
124124
"//_devDependencies_comment": [
125-
"Every workspace package is listed with `workspace:*`, so that pnpm links it into the root node_modules.",
126-
"Yarn workspaces did this for all packages, and some configs import workspace packages that they do not declare,",
127-
"for example `@sentry-internal/rollup-utils` in the rollup configs."
125+
"`@sentry-internal/node-integration-tests`: its suites import it by name, also from tmp folders with their own package.json.",
126+
"`@sentry/eslint-plugin-sdk`: the root oxlint config loads it as a JS plugin.",
127+
"`@sentry/sveltekit`: size-limit bundles its build output, which imports `@sentry/sveltekit/browser-tracing-variant`."
128128
],
129129
"devDependencies": {
130130
"@rollup/plugin-commonjs": "^25.0.7",
131131
"@rollup/plugin-json": "^6.1.0",
132132
"@rollup/plugin-node-resolve": "^16.0.3",
133133
"@rollup/plugin-replace": "^5.0.5",
134134
"@rollup/plugin-terser": "^0.4.4",
135-
"@sentry-internal/browser-integration-tests": "workspace:*",
136-
"@sentry-internal/bun-integration-tests": "workspace:*",
137-
"@sentry-internal/bundler-plugin-integration-tests": "workspace:*",
138-
"@sentry-internal/bundler-tests": "workspace:*",
139-
"@sentry-internal/clear-cache-gh-action": "workspace:*",
140-
"@sentry-internal/cloudflare-integration-tests": "workspace:*",
141-
"@sentry-internal/deno-integration-tests": "workspace:*",
142-
"@sentry-internal/e2e-tests": "workspace:*",
143-
"@sentry-internal/external-contributor-gh-action": "workspace:*",
144-
"@sentry-internal/integration-shims": "workspace:*",
145135
"@sentry-internal/node-integration-tests": "workspace:*",
146-
"@sentry-internal/replay-worker": "workspace:*",
147-
"@sentry-internal/rollup-utils": "workspace:*",
148-
"@sentry-internal/size-limit-gh-action": "workspace:*",
149-
"@sentry-internal/test-utils": "workspace:*",
150-
"@sentry/angular": "workspace:*",
151-
"@sentry/astro": "workspace:*",
152-
"@sentry/aws-serverless": "workspace:*",
153-
"@sentry/browser": "workspace:*",
154-
"@sentry/browser-utils": "workspace:*",
155-
"@sentry/bun": "workspace:*",
156-
"@sentry/bundler-plugins": "workspace:*",
157-
"@sentry/cloudflare": "workspace:*",
158-
"@sentry/core": "workspace:*",
159-
"@sentry/deno": "workspace:*",
160-
"@sentry/effect": "workspace:*",
161-
"@sentry/elysia": "workspace:*",
162-
"@sentry/ember": "workspace:*",
163-
"@sentry/esbuild-plugin": "workspace:*",
164-
"@sentry/eslint-config-sdk": "workspace:*",
165136
"@sentry/eslint-plugin-sdk": "workspace:*",
166-
"@sentry/feedback": "workspace:*",
167-
"@sentry/gatsby": "workspace:*",
168-
"@sentry/google-cloud-serverless": "workspace:*",
169-
"@sentry/hono": "workspace:*",
170-
"@sentry/nestjs": "workspace:*",
171-
"@sentry/nextjs": "workspace:*",
172-
"@sentry/nitro": "workspace:*",
173-
"@sentry/node": "workspace:*",
174-
"@sentry/node-native": "workspace:*",
175-
"@sentry/nuxt": "workspace:*",
176-
"@sentry/opentelemetry": "workspace:*",
177-
"@sentry/profiling-node": "workspace:*",
178-
"@sentry/react": "workspace:*",
179-
"@sentry/react-router": "workspace:*",
180-
"@sentry/remix": "workspace:*",
181-
"@sentry/replay": "workspace:*",
182-
"@sentry/replay-canvas": "workspace:*",
183-
"@sentry/rollup-plugin": "workspace:*",
184-
"@sentry/server-runtime-injection": "workspace:*",
185-
"@sentry/server-utils": "workspace:*",
186-
"@sentry/solid": "workspace:*",
187-
"@sentry/solidstart": "workspace:*",
188-
"@sentry/svelte": "workspace:*",
189137
"@sentry/sveltekit": "workspace:*",
190-
"@sentry/tanstackstart-react": "workspace:*",
191-
"@sentry/typescript": "workspace:*",
192-
"@sentry/vercel-edge": "workspace:*",
193-
"@sentry/vite-plugin": "workspace:*",
194-
"@sentry/vue": "workspace:*",
195-
"@sentry/wasm": "workspace:*",
196-
"@sentry/webpack-plugin": "workspace:*",
197138
"@size-limit/esbuild": "~12.1.0",
198139
"@size-limit/file": "~12.1.0",
199140
"@size-limit/webpack": "~12.1.0",

‎packages/astro/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@
6060
"@sentry/bundler-plugins": "11.8.0"
6161
},
6262
"devDependencies": {
63+
"@sentry-internal/rollup-utils": "11.8.0",
6364
"astro": "^4.16.19",
6465
"vite": "^8.3.1"
6566
},

‎packages/aws-serverless/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
"@types/aws-lambda": "^8.10.161"
6565
},
6666
"devDependencies": {
67+
"@sentry-internal/rollup-utils": "11.8.0",
6768
"@types/node": "^18.19.1",
6869
"@vercel/nft": "^1.11.0"
6970
},

‎packages/browser-utils/package.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@
3737
"@sentry/conventions": "^0.27.0",
3838
"web-vitals": "^6.2.3"
3939
},
40+
"devDependencies": {
41+
"@sentry-internal/rollup-utils": "11.8.0"
42+
},
4043
"scripts": {
4144
"build": "run-p build:transpile build:types",
4245
"build:dev": "pnpm run build",

‎packages/browser/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
},
4848
"devDependencies": {
4949
"@sentry-internal/integration-shims": "11.8.0",
50+
"@sentry-internal/rollup-utils": "11.8.0",
5051
"fake-indexeddb": "^6.2.5"
5152
},
5253
"scripts": {

‎packages/bun/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"@sentry/server-utils": "11.8.0"
5050
},
5151
"devDependencies": {
52+
"@sentry-internal/rollup-utils": "11.8.0",
5253
"bun-types": "^1.2.9"
5354
},
5455
"scripts": {

0 commit comments

Comments
 (0)