fix: align simulator app path platform typing

Author: cameroncooke

src/mcp/tools/simulator/__tests__/get_sim_app_path.test.ts

@@ -10,6 +10,7 @@ import { createMockExecutor } from '../../../../test-utils/mock-executors.ts';
 import { sessionStore } from '../../../../utils/session-store.ts';
 import { schema, handler, get_sim_app_pathLogic } from '../get_sim_app_path.ts';
 import type { CommandExecutor } from '../../../../utils/CommandExecutor.ts';
+import { XcodePlatform } from '../../../../types/common.ts';
 
 describe('get_sim_app_path tool', () => {
   beforeEach(() => {
@@ -24,7 +25,7 @@ describe('get_sim_app_path tool', () => {
     it('should expose only platform in public schema', () => {
       const schemaObj = z.object(schema);
 
-      expect(schemaObj.safeParse({ platform: 'iOS Simulator' }).success).toBe(true);
+      expect(schemaObj.safeParse({ platform: XcodePlatform.iOSSimulator }).success).toBe(true);
       expect(schemaObj.safeParse({}).success).toBe(false);
       expect(schemaObj.safeParse({ platform: 'iOS' }).success).toBe(false);
 
@@ -36,7 +37,7 @@ describe('get_sim_app_path tool', () => {
   describe('Handler Requirements', () => {
     it('should require scheme when not provided', async () => {
       const result = await handler({
-        platform: 'iOS Simulator',
+        platform: XcodePlatform.iOSSimulator,
       });
 
       expect(result.isError).toBe(true);
@@ -47,7 +48,7 @@ describe('get_sim_app_path tool', () => {
       sessionStore.setDefaults({ scheme: 'MyScheme' });
 
       const result = await handler({
-        platform: 'iOS Simulator',
+        platform: XcodePlatform.iOSSimulator,
       });
 
       expect(result.isError).toBe(true);
@@ -61,7 +62,7 @@ describe('get_sim_app_path tool', () => {
       });
 
       const result = await handler({
-        platform: 'iOS Simulator',
+        platform: XcodePlatform.iOSSimulator,
       });
 
       expect(result.isError).toBe(true);
@@ -72,7 +73,7 @@ describe('get_sim_app_path tool', () => {
       sessionStore.setDefaults({ scheme: 'MyScheme' });
 
       const result = await handler({
-        platform: 'iOS Simulator',
+        platform: XcodePlatform.iOSSimulator,
         projectPath: '/path/project.xcodeproj',
         workspacePath: '/path/workspace.xcworkspace',
       });
@@ -90,7 +91,7 @@ describe('get_sim_app_path tool', () => {
       });
 
       const result = await handler({
-        platform: 'iOS Simulator',
+        platform: XcodePlatform.iOSSimulator,
         simulatorId: 'SIM-UUID',
         simulatorName: 'iPhone 16',
       });
@@ -134,7 +135,7 @@ describe('get_sim_app_path tool', () => {
         {
           workspacePath: '/path/to/workspace.xcworkspace',
           scheme: 'MyScheme',
-          platform: 'iOS Simulator',
+          platform: XcodePlatform.iOSSimulator,
           simulatorName: 'iPhone 16',
           useLatestOS: true,
         },
@@ -173,7 +174,7 @@ describe('get_sim_app_path tool', () => {
         {
           projectPath: '/path/to/project.xcodeproj',
           scheme: 'MyScheme',
-          platform: 'iOS Simulator',
+          platform: XcodePlatform.iOSSimulator,
           simulatorId: 'SIM-UUID',
         },
         mockExecutor,

src/mcp/tools/simulator/get_sim_app_path.ts

@@ -19,19 +19,23 @@ import {
 } from '../../../utils/typed-tool-factory.ts';
 import { nullifyEmptyStrings } from '../../../utils/schema-helpers.ts';
 
+const SIMULATOR_PLATFORMS = [
+  XcodePlatform.iOSSimulator,
+  XcodePlatform.watchOSSimulator,
+  XcodePlatform.tvOSSimulator,
+  XcodePlatform.visionOSSimulator,
+] as const;
+
 function constructDestinationString(
-  platform: string,
+  platform: XcodePlatform,
   simulatorName: string,
   simulatorId: string,
   useLatest: boolean = true,
   arch?: string,
 ): string {
-  const isSimulatorPlatform = [
-    XcodePlatform.iOSSimulator,
-    XcodePlatform.watchOSSimulator,
-    XcodePlatform.tvOSSimulator,
-    XcodePlatform.visionOSSimulator,
-  ].includes(platform);
+  const isSimulatorPlatform = SIMULATOR_PLATFORMS.includes(
+    platform as (typeof SIMULATOR_PLATFORMS)[number],
+  );
 
   // If ID is provided for a simulator, it takes precedence and uniquely identifies it.
   if (isSimulatorPlatform && simulatorId) {
@@ -76,7 +80,14 @@ const baseGetSimulatorAppPathSchema = z.object({
     .optional()
     .describe('Path to .xcworkspace file. Provide EITHER this OR projectPath, not both'),
   scheme: z.string().describe('The scheme to use (Required)'),
-  platform: z.enum(['iOS Simulator', 'watchOS Simulator', 'tvOS Simulator', 'visionOS Simulator']),
+  platform: z
+    .nativeEnum(XcodePlatform)
+    .refine(
+      (platform) => SIMULATOR_PLATFORMS.includes(platform as (typeof SIMULATOR_PLATFORMS)[number]),
+      {
+        message: 'platform must be a simulator platform',
+      },
+    ),
   simulatorId: z
     .string()
     .optional()
@@ -162,12 +173,9 @@ export async function get_sim_app_pathLogic(
     command.push('-configuration', configuration);
 
     // Handle destination based on platform
-    const isSimulatorPlatform = [
-      XcodePlatform.iOSSimulator,
-      XcodePlatform.watchOSSimulator,
-      XcodePlatform.tvOSSimulator,
-      XcodePlatform.visionOSSimulator,
-    ].includes(platform);
+    const isSimulatorPlatform = SIMULATOR_PLATFORMS.includes(
+      platform as (typeof SIMULATOR_PLATFORMS)[number],
+    );
 
     let destinationString = '';