Skip to content

Commit 3141b67

Browse files
committed
fix: Fix ESLint configuration to properly ignore generated-plugins.ts
- Move ignores to separate config object for consistent behavior - Remove unnecessary eslint-disable comment from generated file - Fix GitHub Actions linting errors while maintaining local compatibility
1 parent 758fc6f commit 3141b67

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

build-plugins/plugin-discovery.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,6 @@ function generatePluginsFileContent(workflowLoaders, workflowMetadata) {
210210
return `// AUTO-GENERATED - DO NOT EDIT
211211
// This file is generated by the plugin discovery esbuild plugin
212212
213-
/* eslint-disable @typescript-eslint/explicit-function-return-type */
214-
215213
// Generated based on filesystem scan
216214
export const WORKFLOW_LOADERS = {
217215
${loaderEntries}

eslint.config.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ import prettierPlugin from 'eslint-plugin-prettier';
55
export default [
66
eslint.configs.recommended,
77
...tseslint.configs.recommended,
8+
{
9+
ignores: ['node_modules/**', 'build/**', 'dist/**', 'coverage/**', 'src/core/generated-plugins.ts'],
10+
},
811
{
912
files: ['**/*.{js,ts}'],
10-
ignores: ['node_modules/**', 'build/**', 'dist/**', 'coverage/**', '**/*.test.ts'],
1113
languageOptions: {
1214
ecmaVersion: 2020,
1315
sourceType: 'module',
@@ -46,10 +48,4 @@ export default [
4648
'prefer-const': 'off',
4749
},
4850
},
49-
{
50-
files: ['src/core/generated-plugins.ts'],
51-
rules: {
52-
'@typescript-eslint/explicit-function-return-type': 'off',
53-
},
54-
},
5551
];

0 commit comments

Comments
 (0)