From b3803f7f248c208f1264cba44825e478f991ed16 Mon Sep 17 00:00:00 2001 From: Lander San Millan Date: Mon, 24 May 2021 20:25:49 +0200 Subject: [PATCH 1/2] Creados tests de integracion para DeustockGateway [STOCKS] --- DeustockClient/pom.xml | 20 +++ .../controllers/UserDetailController.java | 1 - .../stocks/StockListViewController.java | 1 - .../client/gateways/DeustockGatewayIT.java | 131 ++++++++++++++++++ 4 files changed, 151 insertions(+), 2 deletions(-) create mode 100644 DeustockClient/src/test/java/es/deusto/deustock/client/gateways/DeustockGatewayIT.java diff --git a/DeustockClient/pom.xml b/DeustockClient/pom.xml index 5063a99a..4eb93f18 100644 --- a/DeustockClient/pom.xml +++ b/DeustockClient/pom.xml @@ -77,6 +77,26 @@ + + org.apache.maven.plugins + maven-failsafe-plugin + 3.0.0-M5 + + + **/*IT + + --enable-preview + + + + + integration-test + verify + + + + + com.soebes.maven.plugins doxygen-maven-plugin diff --git a/DeustockClient/src/main/java/es/deusto/deustock/client/controllers/UserDetailController.java b/DeustockClient/src/main/java/es/deusto/deustock/client/controllers/UserDetailController.java index bcf71dc1..c3fd43d3 100644 --- a/DeustockClient/src/main/java/es/deusto/deustock/client/controllers/UserDetailController.java +++ b/DeustockClient/src/main/java/es/deusto/deustock/client/controllers/UserDetailController.java @@ -82,7 +82,6 @@ public void setParams(HashMap params) { } initRoot(); - } /** diff --git a/DeustockClient/src/main/java/es/deusto/deustock/client/controllers/stocks/StockListViewController.java b/DeustockClient/src/main/java/es/deusto/deustock/client/controllers/stocks/StockListViewController.java index caf69ed7..347cd84e 100644 --- a/DeustockClient/src/main/java/es/deusto/deustock/client/controllers/stocks/StockListViewController.java +++ b/DeustockClient/src/main/java/es/deusto/deustock/client/controllers/stocks/StockListViewController.java @@ -136,7 +136,6 @@ public void refreshStocks(){ /** * Method that cleans the stock list and leaves it empty */ - private void emptyStockList(){ stockLines.clear(); stockList.getChildren().removeIf( diff --git a/DeustockClient/src/test/java/es/deusto/deustock/client/gateways/DeustockGatewayIT.java b/DeustockClient/src/test/java/es/deusto/deustock/client/gateways/DeustockGatewayIT.java new file mode 100644 index 00000000..4c4763a7 --- /dev/null +++ b/DeustockClient/src/test/java/es/deusto/deustock/client/gateways/DeustockGatewayIT.java @@ -0,0 +1,131 @@ +package es.deusto.deustock.client.gateways; + +import es.deusto.deustock.client.data.Stock; +import es.deusto.deustock.client.simulation.investment.operations.OperationType; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.api.Test; + +import java.io.File; +import java.io.IOException; +import java.util.List; + +import static org.junit.Assert.*; +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; + + +/** + * Integration test for the functionality between the client and the DeuStock Server + * @author landersanmi + */ +@Tag("integration-resource") +public class DeustockGatewayIT { + + private DeustockGateway gateway = new DeustockGateway(); + + @Test + void testGetStockReturnsNotNull(){ + //When + Stock stock = gateway.getStock("BB", "DAILY"); + //Then + assertNotNull(stock); + } + + @Test + void testGetStockReturnsNull(){ + //When + Stock stock = gateway.getStock("BB", "TESTING"); + //Then + assertNull(stock); + } + + @Test + void testGetSearchedStockReturnsNotNull(){ + //When + Stock stock = gateway.getSearchedStock("BB"); + //Then + assertNotNull(stock); + } + + @Test + void testGetSearchedStockReturnsNull(){ + //When + Stock stock = gateway.getSearchedStock("NULL_STOCK"); + //Then + assertNull(stock); + } + + @Test + void testGetTwitterSentiment(){ + //When + double result = gateway.getTwitterSentiment("Happy"); + double result2 = gateway.getTwitterSentiment("Angry"); + //Then + assertTrue(result>2); + assertTrue(result2<2); + } + + @Test + void testGetStockListReturnsNotNull(){ + //When + List stockList = gateway.getStockList("big"); + //Then + assertNotNull(stockList); + } + + @Test + void testGetStockListReturnsNull(){ + //When + List stockList = gateway.getStockList("NULL_LIST_TYPE"); + //Then + assertNull(stockList); + } + + @Test + void testGetStockReportReturnsNotNull() throws IOException { + //When + File file = gateway.getStockReport("BB", "DAILY", "../"); + byte[] file2 = gateway.getStockReport("BB", "DAILY"); + //Then + assertNotNull(file); + assertNotNull(file2); + } + + @Test + void testResetHoldingsReturnsFalse(){ + //When & Then + assertFalse(gateway.resetHoldings("NULL_USER")); + } + @Test + void testGetBalanceReturnsNullPointer(){ + //When & Then + assertThrows(NullPointerException.class, () -> gateway.getBalance("NULL_USER")); + } + + @Test + void testOpenOperationReturnsIllegalArgumentException(){ + assertThrows(IllegalArgumentException.class, () -> gateway.openOperation(null, null, "sdsdsdsdafsdg", 20)); + assertThrows(IllegalArgumentException.class, ()-> gateway.openOperation(OperationType.LONG, null, "dhasofdjpiasd", -1)); + } + + @Test + void testOpenOperationWith0Cuantity(){ + assertDoesNotThrow(() -> gateway.openOperation(OperationType.LONG, null, "sdsdsdsdafsdg", 0)); + } + + @Test + void testOpenOperationReturnsNullPointer(){ + assertThrows(NullPointerException.class, () -> gateway.openOperation(OperationType.LONG, null, "fjdsnfsd", 2)); + } + + @Test + void testCloseOperation(){ + assertDoesNotThrow( ()-> gateway.closeOperation("fbndif", "nfdjnagrf")); + } + + + + + + + +} From 99de5f5fe4c054fabb930c7976cda8b8f5a3cfb2 Mon Sep 17 00:00:00 2001 From: Lander San Millan Date: Mon, 24 May 2021 20:50:07 +0200 Subject: [PATCH 2/2] =?UTF-8?q?prueba=20pre-integration=20a=C3=B1adido?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- DeuStock/pom.xml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/DeuStock/pom.xml b/DeuStock/pom.xml index 8d8047a5..97972c54 100644 --- a/DeuStock/pom.xml +++ b/DeuStock/pom.xml @@ -479,6 +479,14 @@ + + + pre-integration-test + + java + + +