Skip to content

Commit f624044

Browse files
sbyrne-sfsbyrne-sf
committed
Renamed for clarity.
1 parent 2807a26 commit f624044

3 files changed

Lines changed: 19 additions & 19 deletions

File tree

‎src/datacustomcode/cli.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def deploy(
170170
network: str,
171171
):
172172
from datacustomcode.credentials import Credentials
173-
from datacustomcode.deploy import TransformationJobMetadata, deploy_full
173+
from datacustomcode.deploy import CodeExtensionMetadata, deploy_full
174174

175175
logger.debug("Deploying project")
176176

@@ -187,7 +187,7 @@ def deploy(
187187

188188
logger.debug(f"Deploying with CPU size: {cpu_size}")
189189

190-
metadata = TransformationJobMetadata(
190+
metadata = CodeExtensionMetadata(
191191
name=name,
192192
version=version,
193193
description=description,

‎src/datacustomcode/deploy.py‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
}
5757

5858

59-
class TransformationJobMetadata(BaseModel):
59+
class CodeExtensionMetadata(BaseModel):
6060
name: str
6161
version: str
6262
description: str
@@ -149,7 +149,7 @@ class CreateDeploymentResponse(BaseModel):
149149

150150

151151
def create_deployment(
152-
access_token: AccessTokenResponse, metadata: TransformationJobMetadata
152+
access_token: AccessTokenResponse, metadata: CodeExtensionMetadata
153153
) -> CreateDeploymentResponse:
154154
"""Create a custom code deployment in the DataCloud."""
155155
url = _join_strip_url(access_token.instance_url, DATA_CUSTOM_CODE_PATH)
@@ -238,7 +238,7 @@ class DeploymentsResponse(BaseModel):
238238

239239

240240
def get_deployments(
241-
access_token: AccessTokenResponse, metadata: TransformationJobMetadata
241+
access_token: AccessTokenResponse, metadata: CodeExtensionMetadata
242242
) -> DeploymentsResponse:
243243
"""Get all custom code deployments from the DataCloud."""
244244
url = _join_strip_url(
@@ -250,7 +250,7 @@ def get_deployments(
250250

251251
def wait_for_deployment(
252252
access_token: AccessTokenResponse,
253-
metadata: TransformationJobMetadata,
253+
metadata: CodeExtensionMetadata,
254254
callback: Union[Callable[[str], None], None] = None,
255255
) -> None:
256256
"""Wait for deployment to complete.
@@ -340,7 +340,7 @@ def get_config(directory: str) -> BaseConfig:
340340
def create_data_transform(
341341
directory: str,
342342
access_token: AccessTokenResponse,
343-
metadata: TransformationJobMetadata,
343+
metadata: CodeExtensionMetadata,
344344
data_transform_config: DataTransformConfig,
345345
) -> dict:
346346
"""Create a data transform in the DataCloud."""
@@ -445,7 +445,7 @@ def zip(
445445

446446
def deploy_full(
447447
directory: str,
448-
metadata: TransformationJobMetadata,
448+
metadata: CodeExtensionMetadata,
449449
credentials: Credentials,
450450
docker_network: str,
451451
callback=None,
@@ -470,7 +470,7 @@ def deploy_full(
470470

471471

472472
def run_data_transform(
473-
access_token: AccessTokenResponse, metadata: TransformationJobMetadata
473+
access_token: AccessTokenResponse, metadata: CodeExtensionMetadata
474474
) -> dict:
475475
logger.debug(f"Triggering data transform {metadata.name}")
476476
url = _join_strip_url(

‎tests/test_deploy.py‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
with patch("datacustomcode.version.get_version", return_value="1.2.3"):
2222
from datacustomcode.deploy import (
2323
AccessTokenResponse,
24+
CodeExtensionMetadata,
2425
CreateDeploymentResponse,
2526
DataTransformConfig,
2627
DeploymentsResponse,
27-
TransformationJobMetadata,
2828
_make_api_call,
2929
_retrieve_access_token,
3030
create_data_transform,
@@ -491,7 +491,7 @@ def test_create_deployment_success(self, mock_make_api_call):
491491
access_token = AccessTokenResponse(
492492
access_token="test_token", instance_url="https://instance.example.com"
493493
)
494-
metadata = TransformationJobMetadata(
494+
metadata = CodeExtensionMetadata(
495495
name="test_job",
496496
version="1.0.0",
497497
description="Test job",
@@ -514,7 +514,7 @@ def test_create_deployment_conflict(self, mock_make_api_call):
514514
access_token = AccessTokenResponse(
515515
access_token="test_token", instance_url="https://instance.example.com"
516516
)
517-
metadata = TransformationJobMetadata(
517+
metadata = CodeExtensionMetadata(
518518
name="test_job",
519519
version="1.0.0",
520520
description="Test job",
@@ -634,7 +634,7 @@ def test_get_deployments(self, mock_make_api_call):
634634
access_token = AccessTokenResponse(
635635
access_token="test_token", instance_url="https://instance.example.com"
636636
)
637-
metadata = TransformationJobMetadata(
637+
metadata = CodeExtensionMetadata(
638638
name="test_job",
639639
version="1.0.0",
640640
description="Test job",
@@ -661,7 +661,7 @@ def test_wait_for_deployment_success(
661661
access_token = AccessTokenResponse(
662662
access_token="test_token", instance_url="https://instance.example.com"
663663
)
664-
metadata = TransformationJobMetadata(
664+
metadata = CodeExtensionMetadata(
665665
name="test_job",
666666
version="1.0.0",
667667
description="Test job",
@@ -691,7 +691,7 @@ def test_wait_for_deployment_timeout(
691691
access_token = AccessTokenResponse(
692692
access_token="test_token", instance_url="https://instance.example.com"
693693
)
694-
metadata = TransformationJobMetadata(
694+
metadata = CodeExtensionMetadata(
695695
name="test_job",
696696
version="1.0.0",
697697
description="Test job",
@@ -771,7 +771,7 @@ def test_create_data_transform(self, mock_make_api_call, mock_get_config):
771771
access_token = AccessTokenResponse(
772772
access_token="test_token", instance_url="https://instance.example.com"
773773
)
774-
metadata = TransformationJobMetadata(
774+
metadata = CodeExtensionMetadata(
775775
name="test_job",
776776
version="1.0.0",
777777
description="Test job",
@@ -849,7 +849,7 @@ def test_deploy_full(
849849
password="pass",
850850
client_secret="secret",
851851
)
852-
metadata = TransformationJobMetadata(
852+
metadata = CodeExtensionMetadata(
853853
name="test_job",
854854
version="1.0.0",
855855
description="Test job",
@@ -889,7 +889,7 @@ def test_run_data_transform(self, mock_make_api_call):
889889
access_token = AccessTokenResponse(
890890
access_token="test_token", instance_url="https://instance.example.com"
891891
)
892-
metadata = TransformationJobMetadata(
892+
metadata = CodeExtensionMetadata(
893893
name="test_job",
894894
version="1.0.0",
895895
description="Test job",
@@ -933,7 +933,7 @@ def test_deploy_full_happy_path(
933933
password="pass",
934934
client_secret="secret",
935935
)
936-
metadata = TransformationJobMetadata(
936+
metadata = CodeExtensionMetadata(
937937
name="test_job",
938938
version="1.0.0",
939939
description="Test job",

0 commit comments

Comments
 (0)