address comments

Author: ppandit-sfdc

README.md

@@ -79,7 +79,6 @@ After modifying the `entrypoint.py` as needed, using any dependencies you add in
 ```zsh
 cd my_package
 datacustomcode scan ./payload/entrypoint.py
-datacustomcode zip --path ./payload
 datacustomcode deploy --path ./payload --name my_custom_script --cpu-size CPU_L
 ```
 

src/datacustomcode/scan.py

@@ -249,17 +249,17 @@ def dc_config_json_from_file(file_path: str) -> dict[str, Any]:
                 if not dataspace_value or (
                     isinstance(dataspace_value, str) and dataspace_value.strip() == ""
                 ):
-                    logger.error(
-                        f"dataspace in {config_json_path} is empty or None."
-                        f"Updating config file to use dataspace 'default'."
+                    logger.warning(
+                        f"dataspace in {config_json_path} is empty or None. "
+                        f"Updating config file to use dataspace 'default'. "
                     )
                     config["dataspace"] = "default"
                 else:
                     config["dataspace"] = dataspace_value
             else:
                 raise ValueError(
                     f"dataspace must be defined in {config_json_path}. "
-                    f"Please add a 'dataspace' field to the config.json file."
+                    f"Please add a 'dataspace' field to the config.json file. "
                 )
         except json.JSONDecodeError as e:
             raise ValueError(

tests/test_scan.py

@@ -423,9 +423,10 @@ def test_preserves_existing_dataspace(self):
             },
         },
     )
-    def test_rejects_empty_dataspace(self):
-        """Test that empty dataspace value uses default and logs error."""
+    def test_uses_default_for_empty_dataspace(self, caplog):
+        """Test that empty dataspace value uses default and logs warning."""
         import json
+        import logging
 
         content = textwrap.dedent(
             """
@@ -455,10 +456,20 @@ def test_rejects_empty_dataspace(self):
                 json.dump(existing_config, f)
 
             # Should use "default" for empty dataspace (not raise error)
-            result = dc_config_json_from_file(temp_path)
+            with caplog.at_level(logging.WARNING):
+                result = dc_config_json_from_file(temp_path)
+
             assert result["dataspace"] == "default"
             assert result["permissions"]["read"]["dlo"] == ["input_dlo"]
             assert result["permissions"]["write"]["dlo"] == ["output_dlo"]
+
+            # Verify that a warning was logged
+            assert len(caplog.records) > 0
+            assert any(
+                "dataspace" in record.message.lower()
+                and "empty" in record.message.lower()
+                for record in caplog.records
+            )
         finally:
             os.remove(temp_path)
             if os.path.exists(config_path):
@@ -476,7 +487,7 @@ def test_rejects_empty_dataspace(self):
             },
         },
     )
-    def test_rejects_missing_dataspace(self):
+    def test_uses_default_dataspace_when_no_config(self):
         """Test missing config.json uses default dataspace."""
         content = textwrap.dedent(
             """
@@ -498,6 +509,58 @@ def test_rejects_missing_dataspace(self):
         finally:
             os.remove(temp_path)
 
+    @patch(
+        "datacustomcode.scan.DATA_TRANSFORM_CONFIG_TEMPLATE",
+        {
+            "sdkVersion": "1.2.3",
+            "entryPoint": "",
+            "dataspace": "",
+            "permissions": {
+                "read": {},
+                "write": {},
+            },
+        },
+    )
+    def test_rejects_missing_dataspace(self):
+        """Test that config.json missing dataspace field raises ValueError."""
+        import json
+
+        content = textwrap.dedent(
+            """
+            from datacustomcode.client import Client
+
+            client = Client()
+            df = client.read_dlo("input_dlo")
+            client.write_to_dlo("output_dlo", df, "overwrite")
+        """
+        )
+        temp_path = create_test_script(content)
+        file_dir = os.path.dirname(temp_path)
+        config_path = os.path.join(file_dir, "config.json")
+
+        try:
+            # Create an existing config.json without dataspace field
+            existing_config = {
+                "sdkVersion": "1.0.0",
+                "entryPoint": "test.py",
+                "permissions": {
+                    "read": {"dlo": ["old_dlo"]},
+                    "write": {"dlo": ["old_output"]},
+                },
+            }
+            with open(config_path, "w") as f:
+                json.dump(existing_config, f)
+
+            # Should raise ValueError when dataspace field is missing
+            with pytest.raises(
+                ValueError, match="dataspace must be defined in.*config.json"
+            ):
+                dc_config_json_from_file(temp_path)
+        finally:
+            os.remove(temp_path)
+            if os.path.exists(config_path):
+                os.remove(config_path)
+
     def test_raises_error_on_invalid_json(self):
         """Test that invalid JSON in config.json raises an error."""