update

Author: ppandit-sfdc

tests/test_credentials.py

@@ -18,7 +18,7 @@ def test_from_env(self):
             "client_id": "test_client_id",
             "client_secret": "test_secret",
             "login_url": "https://test.login.url",
-            "dataspace": "test_dataspace",  # Added dataspace
+            "dataspace": "test_dataspace",
         }
 
         with patch.dict(
@@ -31,7 +31,7 @@ def test_from_env(self):
             assert creds.client_id == test_creds["client_id"]
             assert creds.client_secret == test_creds["client_secret"]
             assert creds.login_url == test_creds["login_url"]
-            assert creds.dataspace == test_creds["dataspace"]  # Added dataspace assertion
+            assert creds.dataspace == test_creds["dataspace"]
 
     def test_from_env_without_dataspace(self):
         """Test loading credentials from environment variables without dataspace."""
@@ -44,8 +44,10 @@ def test_from_env_without_dataspace(self):
         }
 
         # Create env dict without dataspace
-        env_dict = {v: test_creds[k] for k, v in ENV_CREDENTIALS.items() if k != "dataspace"}
-        
+        env_dict = {
+            v: test_creds[k] for k, v in ENV_CREDENTIALS.items() if k != "dataspace"
+        }
+
         with patch.dict(os.environ, env_dict, clear=True):
             creds = Credentials.from_env()
 
@@ -121,7 +123,7 @@ def test_from_available_env(self):
             "client_id": "test_client_id",
             "client_secret": "test_secret",
             "login_url": "https://test.login.url",
-            "dataspace": "test_dataspace",  # Added dataspace
+            "dataspace": "test_dataspace",
         }
 
         with (
@@ -137,7 +139,7 @@ def test_from_available_env(self):
             assert creds.client_id == test_creds["client_id"]
             assert creds.client_secret == test_creds["client_secret"]
             assert creds.login_url == test_creds["login_url"]
-            assert creds.dataspace == test_creds["dataspace"]  # Added dataspace assertion
+            assert creds.dataspace == test_creds["dataspace"]
 
     def test_from_available_ini(self):
         """Test that from_available uses INI file when env vars not available."""

tests/test_credentials_profile_integration.py

@@ -32,7 +32,7 @@ def test_query_api_reader_with_custom_profile(self):
             mock_credentials.password = "custom_password"
             mock_credentials.client_id = "custom_client_id"
             mock_credentials.client_secret = "custom_secret"
-            mock_credentials.dataspace = "custom_dataspace"  # Added dataspace
+            mock_credentials.dataspace = "custom_dataspace"
             mock_from_available.return_value = mock_credentials
 
             # Mock the SalesforceCDPConnection
@@ -50,14 +50,15 @@ def test_query_api_reader_with_custom_profile(self):
                 # Verify the correct profile was used
                 mock_from_available.assert_called_with(profile="custom_profile")
 
-                # Verify the connection was created with the custom credentials including dataspace
+                # Verify the connection was created
+                # with the custom credentials including dataspace
                 mock_conn_class.assert_called_once_with(
                     "https://custom.salesforce.com",
                     "custom@example.com",
                     "custom_password",
                     "custom_client_id",
                     "custom_secret",
-                    dataspace="custom_dataspace",  # Added dataspace parameter
+                    dataspace="custom_dataspace",
                 )
 
     def test_query_api_reader_without_dataspace(self):
@@ -92,14 +93,14 @@ def test_query_api_reader_without_dataspace(self):
                 # Verify the correct profile was used
                 mock_from_available.assert_called_with(profile="custom_profile")
 
-                # Verify the connection was created WITHOUT dataspace parameter when None
+                # Verify the connection was created
+                # WITHOUT dataspace parameter when None
                 mock_conn_class.assert_called_once_with(
                     "https://custom.salesforce.com",
                     "custom@example.com",
                     "custom_password",
                     "custom_client_id",
                     "custom_secret",
-                    # No dataspace parameter when None
                 )
 
     def test_print_writer_with_custom_profile(self):