Review comments

Author: ritaagarwala-sf

src/datacustomcode/client.py

@@ -119,8 +119,6 @@ def __new__(
         spark_provider: Optional["BaseSparkSessionProvider"] = None,
         code_type: str = "script",
     ) -> Client:
-        if "function" in code_type:
-            return cls._new_function_client()
 
         if cls._instance is None:
             cls._instance = super().__new__(cls)
@@ -175,16 +173,6 @@ def __new__(
             raise ValueError("Cannot set reader or writer after client is initialized")
         return cls._instance
 
-    @classmethod
-    def _new_function_client(cls) -> Client:
-        cls._instance = super().__new__(cls)
-        cls._instance._proxy = (
-            config.proxy_config.to_object()  # type: ignore
-            if config.proxy_config is not None
-            else None
-        )
-        return cls._instance
-
     def read_dlo(self, name: str) -> PySparkDataFrame:
         """Read a DLO from Data Cloud.
 

src/datacustomcode/runtime/function.py

@@ -28,7 +28,7 @@ class Runtime(BaseRuntime):
     NOTE: Do not instantiate this class directly.
     It will be provided to your function by the SDK:
 
-        def function(request: dict, client: FunctionClient) -> dict:
+        def function(request: dict, runtime: RunTime) -> dict:
             response = {...}
             return response
 
@@ -42,11 +42,11 @@ def __new__(cls):
         with cls._lock:
             if cls._instance is not None:
                 raise RuntimeError(
-                    "FunctionRuntime can only be instantiated once by the SDK.\n\n"
+                    "Runtime can only be instantiated once by the SDK.\n\n"
                     "Do not instantiate it yourself. Accept it as a parameter:\n\n"
-                    "  from datacustomcode.runtime import Function\n"
+                    "  from datacustomcode.runtime.function.RunTime import Function\n"
                     "  \n"
-                    "  def function(request: dict, runtime: FunctionRuntime) -> dict:\n"
+                    "  def function(request: dict, runtime: Runtime) -> dict:\n"
                     "      response = {...}\n"
                     "      return response"
                 )

src/datacustomcode/templates/function/payload/entrypoint.py

@@ -38,7 +38,7 @@ def chunk_text(text: str, chunk_size: int = 1000) -> List[str]:
     return chunks
 
 
-def function(request: dict, runTime: Runtime) -> dict:
+def function(request: dict, runtime: Runtime) -> dict:
     logger.info("Inside Function")
     logger.info(request)
 
@@ -48,7 +48,7 @@ def function(request: dict, runTime: Runtime) -> dict:
 
     builder = GenerateTextRequestBuilder()
     llm_request = builder.set_prompt("Hello").set_model("modelName").build()
-    llm_response = runTime.llm_gateway.generate_text(llm_request)
+    llm_response = runtime.llm_gateway.generate_text(llm_request)
 
     if llm_response.is_success:
         print(llm_response.text)