Please HELP with Windows syntax

Author: mdboom

bench_runner/scripts/workflow.py

@@ -202,9 +202,9 @@ def compile_windows(
     if "CLANG" in flags:
         args.extend(
             [
-                '"/p:PlatformToolset`=clangcl"',
-                r"/p:LLVMInstallDir=C:\Program Files\LLVM",
-                r"/p:LLVMToolsVersion=19.1.6",
+                "/p:PlatformToolset`=clangcl",
+                "/p:LLVMInstallDir`=C:\\Program Files\\LLVM",
+                "/p:LLVMToolsVersion`=19.1.6",
                 "--tail-call-interp",
             ]
         )
@@ -215,7 +215,6 @@ def compile_windows(
                 Path("PCbuild") / "build.bat",
                 *args,
             ],
-            shell=True,
         )
         shutil.copytree(get_windows_build_dir(force_32bit), "libs", dirs_exist_ok=True)
 

bench_runner/templates/_benchmark.src.yml

@@ -72,7 +72,6 @@ jobs:
         run: |
           git gc
       - name: Building Python and running pyperformance
-        shell: cmd
         run: |
           python workflow_bootstrap.py ${{ inputs.fork }} ${{ inputs.ref }} ${{ inputs.machine }} ${{ inputs.benchmarks || 'all' }} "${{ env.flags }}" ${{ inputs.force && '--force' || '' }} ${{ inputs.pgo && '--pgo' || '' }} --run_id ${{ github.run_id }}
       # Pull again, since another job may have committed results in the meantime