Skip to content

Commit d39bc0a

Browse files
committed
Declare BAZEL_USE_HOST_SYSROOT environment variable in the envoy repo… (#43731)
Commit Message: It's a followup for #43681 - after spllitting sysroot from the toolchain I didn't push the local change that declares `BAZEL_USE_HOST_SYSROOT` environment variable in the repository rule. As a result local tests passed (because I had that change locally) and remote tests passed (because they don't test setup without sysroot), but if you checkout state from the upstream repository building with host sysroot still uses Envoy provided sysroot and that results in error of finding the right libraries. Additional Description: It does not break any builds that worked before, but without this commit setting `BAZEL_USE_HOST_SYSROOT` also does not do anything, as it's ignored. Risk Level: low Testing: built locally Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Mikhail Krinkin <mkrinkin@microsoft.com>
1 parent 5d50e84 commit d39bc0a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

bazel/repo.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ _envoy_repo = repository_rule(
303303
"envoy_ci_config": attr.label(default = "@envoy//:.github/config.yml"),
304304
"yq": attr.label(default = "@yq"),
305305
},
306-
environ = ["BAZEL_LLVM_PATH"],
306+
environ = ["BAZEL_LLVM_PATH", "BAZEL_USE_HOST_SYSROOT"],
307307
)
308308

309309
def envoy_repo():

0 commit comments

Comments
 (0)