Enable wasm64 testing under spidermonkey. NFC (#26719)

Author: sbc100

.circleci/config.yml

@@ -942,6 +942,7 @@ jobs:
             echo "JS_ENGINES = [SPIDERMONKEY_ENGINE]" >> ~/emsdk/.emscripten
       - run-tests:
           test_targets: "
+            other.test_stdint_limits_wasm64
             core0.test_hello_argc
             core2.test_demangle_stacks_symbol_map"
       - upload-test-results
@@ -1416,7 +1417,7 @@ workflows:
       #- test-bun
       #- test-deno
       #- test-jsc
-      #- test-spidermonkey
+      - test-spidermonkey
       #- test-node-compat
       #- test-windows
       #- test-windows-browser-firefox

test/common.py

@@ -285,6 +285,11 @@ def engine_is_v8(engine):
   return match_engine_executable(engine, 'd8') or match_engine_executable(engine, 'v8')
 
 
+def engine_is_spidermonkey(engine):
+  assert type(engine) is list
+  return match_engine_executable(engine, 'spidermonkey')
+
+
 def engine_is_deno(engine):
   assert type(engine) is list
   return match_engine_executable(engine, 'deno')
@@ -311,6 +316,10 @@ def get_v8():
   return get_engine(engine_is_v8)
 
 
+def get_spidermonkey():
+  return get_engine(engine_is_spidermonkey)
+
+
 def get_bun():
   return get_engine(engine_is_bun)
 
@@ -499,6 +508,12 @@ def require_wasm64(self):
     if self.try_require_node_version(24):
       return
 
+    spidermonkey = get_spidermonkey()
+    if spidermonkey:
+      self.cflags.append('-sENVIRONMENT=shell')
+      self.require_engine(spidermonkey)
+      return
+
     v8 = get_v8()
     if v8:
       self.cflags.append('-sENVIRONMENT=shell')
@@ -510,7 +525,7 @@ def require_wasm64(self):
   def try_require_node_version(self, major, minor=0, revision=0):
     nodejs = get_nodejs()
     if not nodejs:
-      self.skipTest('Test requires nodejs to run')
+      return False
     version = shared.get_node_version(nodejs)
     if version < (major, minor, revision):
       return False

test/embind/imvu_test_adapter.js

@@ -610,7 +610,7 @@ function run_all_tests() {
             console.log(`${msg.name}: ${msg.verdict}`);
         }
     }
-    const filter = process.env['EMBIND_TESTS'];
+    const filter = globalThis.process?.env['EMBIND_TESTS'];
     run_tests(report_to_stdout, filter);
 }
 

test/embind/underscore-1.4.2.js

@@ -933,14 +933,6 @@
     };
   });
 
-  // Define a fallback version of the method in browsers (ahem, IE), where
-  // there isn't any inspectable "Arguments" type.
-  if (!_.isArguments(arguments)) {
-    _.isArguments = function(obj) {
-      return !!(obj && _.has(obj, 'callee'));
-    };
-  }
-
   // Optimize `isFunction` if appropriate.
   if (typeof (/./) !== 'function') {
     _.isFunction = function(obj) {

test/test_other.py

@@ -13502,6 +13502,7 @@ def test_tutorial(self):
     # Ensure that files referenced in Tutorial.rst are buildable
     self.run_process([EMCC, test_file('hello_world_file.cpp')])
 
+  @crossplatform
   @also_with_wasm64
   def test_stdint_limits(self):
     if self.is_wasm64():