Merge pull request #21104 from emberjs/nvp/reduce-tracerbench-hacks-via-PRing-tracerbench

Reduce tracerbench hacks via PRing tracerbench updates

Author: NullVoxPopuli

bin/benchmark/run.mjs

@@ -171,36 +171,13 @@ async function bootAndRun({ headless = true } = {}) {
     '--debug',
     '--browserArgs',
     [
-      '--no-sandbox',
-      '--crash-dumps-dir=./tmp',
-      // Disable task throttling (also in TracerBench defaults, but explicit here for clarity)
-      '--disable-background-timer-throttling',
-      '--disable-backgrounding-occluded-windows',
-      '--disable-renderer-backgrounding',
-      // Disable caching and unnecessary subsystems
-      '--disable-dev-shm-usage',
-      '--disable-cache',
-      '--disable-v8-idle-tasks',
-      '--disable-breakpad',
-      '--disable-component-update',
-      '--disable-background-networking',
-      '--disable-notifications',
-      '--disable-hang-monitor',
-      '--safebrowsing-disable-auto-update',
-      '--ignore-certificate-errors',
-      '--v8-cache-options=none',
       // Use the new headless mode to support multiple targets
       ...(headless ? ['--headless=new'] : []),
       // GPU: use software rendering via SwiftShader, but do NOT
       // combine --disable-gpu with --use-gl or --disable-software-rasterizer
       // as the contradictory flags cause use-after-free crashes on macOS
       '--disable-gpu',
       '--disable-gpu-compositing',
-      // Disable Chrome ML/TFLite features (suppresses XNNPACK/TFLite init)
-      '--disable-features=TranslateUI',
-      '--disable-features=UseChromiumML',
-      '--disable-features=UseTfLite',
-      '--disable-features=TensorFlowLite',
     ].join(','),
   ];
 

patches/@tracerbench__core@8.0.1.patch

@@ -1,15 +1,60 @@
 diff --git a/dist/create-trace-benchmark.js b/dist/create-trace-benchmark.js
-index 5918e8f7665b3e796ef88283fc40c2b3286a564f..e1a8768964de8b3c16d38bfb6280d836b45aba0b 100644
+index 5918e8f7665b3e796ef88283fc40c2b3286a564f..b9927ba8f639c0a9ecc70144362da439468f1b3a 100644
 --- a/dist/create-trace-benchmark.js
 +++ b/dist/create-trace-benchmark.js
-@@ -45,9 +45,8 @@ function createTraceBenchmark(group, sampleTrace, options = {}) {
+@@ -45,35 +45,27 @@ function createTraceBenchmark(group, sampleTrace, options = {}) {
  }
  exports.default = createTraceBenchmark;
  function getCategories(isTrial, options) {
 -    const categories = ['-*', ...defaultCategories];
-+    const categories = [...defaultCategories];
-     if (isTrial) {
+-    if (isTrial) {
 -        categories.push(...captureAllDevtoolsTimelineCategories, ...captureCpuProfileCategories, captureCpuProfilesHiresCategory, captureFilmStripCategory, ...capturePaintProfileCategories);
-         if (options.additionalTrialCategories) {
-             categories.push(...options.additionalTrialCategories);
-         }
+-        if (options.additionalTrialCategories) {
+-            categories.push(...options.additionalTrialCategories);
+-        }
++    const categories = [...defaultCategories];
++    // include the basic disabled by default devtools categories
++    if (options.captureDevtoolsTimeline) {
++        categories.push(...captureDevtoolsTimelineCategories);
+     }
+-    else {
+-        // include the basic disabled by default devtools categories
+-        if (options.captureDevtoolsTimeline) {
+-            categories.push(...captureDevtoolsTimelineCategories);
+-        }
+-        if (options.captureV8RuntimeStats) {
+-            // this breaks devtools display of CPU profile in dev tools
+-            categories.push(...captureV8RuntimeStatsCategories);
+-        }
+-        if (options.captureCpuProfile) {
+-            // includes runtime samples
+-            categories.push(...captureCpuProfileCategories);
+-        }
+-        if (options.captureFilmStrip) {
+-            categories.push(captureFilmStripCategory);
+-        }
+-        if (options.capturePaintProfile) {
+-            categories.push(...capturePaintProfileCategories);
+-        }
+-        if (options.additionalCategories) {
+-            categories.push(...options.additionalCategories);
+-        }
++    if (options.captureV8RuntimeStats) {
++        // this breaks devtools display of CPU profile in dev tools
++        categories.push(...captureV8RuntimeStatsCategories);
++    }
++    if (options.captureCpuProfile) {
++        // includes runtime samples
++        categories.push(...captureCpuProfileCategories);
++    }
++    if (options.captureFilmStrip) {
++        categories.push(captureFilmStripCategory);
++    }
++    if (options.capturePaintProfile) {
++        categories.push(...capturePaintProfileCategories);
++    }
++    if (options.additionalCategories) {
++        categories.push(...options.additionalCategories);
+     }
+     return categories;
+ }