Merge pull request #21206 from johanrd/cleanup/remove-dead-code

kategengler · web-flow · commit dcfd69cc2440 · 2026-03-10T11:40:24.000-04:00
diff --git a/package.json b/package.json
@@ -67,7 +67,6 @@
   },
   "dependencies": {
     "@babel/core": "^7.24.4",
-    "@ember/edition-utils": "^1.2.0",
     "@embroider/addon-shim": "^1.10.2",
     "@simple-dom/interface": "^1.4.0",
     "backburner.js": "^2.8.0",
@@ -77,12 +76,10 @@
     "chalk": "^4.0.0",
     "ember-cli-babel": "^8.2.0",
     "ember-cli-get-component-path-option": "^1.0.0",
-    "ember-cli-is-package-missing": "^1.0.0",
     "ember-cli-normalize-entity-name": "^1.0.0",
     "ember-cli-path-utils": "^1.0.0",
     "ember-cli-string-utils": "^1.1.0",
     "ember-cli-typescript-blueprint-polyfill": "^0.1.0",
-    "ember-cli-version-checker": "^5.1.2",
     "ember-router-generator": "^2.0.0",
     "inflection": "^2.0.1",
     "route-recognizer": "^0.3.4",
@@ -112,7 +109,6 @@
     "auto-dist-tag": "^2.1.1",
     "babel-plugin-debug-macros": "1.0.0",
     "babel-plugin-ember-template-compilation": "3.0.0-alpha.4",
-    "brotli": "^1.3.3",
     "dag-map": "^2.0.2",
     "decorator-transforms": "2.0.0",
     "ember-cli": "^6.3.0",
@@ -129,23 +125,20 @@
     "eslint-plugin-qunit": "^8.1.2",
     "execa": "^5.1.1",
     "expect-type": "^0.15.0",
-    "filesize": "^10.1.6",
     "fs-extra": "^11.1.1",
     "git-repo-info": "^2.1.1",
     "github": "^0.2.3",
     "glob": "^8.0.3",
     "globals": "^16.0.0",
     "kill-port-process": "^3.2.1",
     "mocha": "^10.2.0",
-    "node-gzip": "^1.1.2",
     "npm-run-all2": "^6.0.6",
     "prettier": "^3.5.3",
     "qunit": "^2.19.4",
     "recast": "^0.22.0",
     "resolve.exports": "^2.0.3",
     "rollup": "^4.57.1",
     "rsvp": "^4.8.5",
-    "table": "^6.9.0",
     "terser": "^5.42.0",
     "testem": "^3.10.1",
     "testem-failure-only-reporter": "^1.0.0",
diff --git a/packages/@ember/-internals/glimmer/lib/component-managers/curly.ts b/packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
@@ -531,11 +531,11 @@ export function initialRenderInstrumentDetails(component: any): any {
   return component.instrumentDetails({ initialRender: true });
 }
 
-export function rerenderInstrumentDetails(component: any): any {
+function rerenderInstrumentDetails(component: any): any {
   return component.instrumentDetails({ initialRender: false });
 }
 
-export const CURLY_CAPABILITIES: InternalComponentCapabilities = {
+const CURLY_CAPABILITIES: InternalComponentCapabilities = {
   dynamicLayout: true,
   dynamicTag: true,
   prepareArgs: true,
diff --git a/packages/@ember/-internals/glimmer/lib/component-managers/root.ts b/packages/@ember/-internals/glimmer/lib/component-managers/root.ts
@@ -78,7 +78,7 @@ class RootComponentManager extends CurlyComponentManager {
 
 // ROOT is the top-level template it has nothing but one yield.
 // it is supposed to have a dummy element
-export const ROOT_CAPABILITIES: InternalComponentCapabilities = {
+const ROOT_CAPABILITIES: InternalComponentCapabilities = {
   dynamicLayout: true,
   dynamicTag: true,
   prepareArgs: false,
diff --git a/packages/@ember/-internals/glimmer/lib/helper.ts b/packages/@ember/-internals/glimmer/lib/helper.ts
@@ -14,7 +14,7 @@ import { getInternalHelperManager, helperCapabilities, setHelperManager } from '
 import type { DirtyableTag } from '@glimmer/validator';
 import { consumeTag, createTag, dirtyTag } from '@glimmer/validator';
 
-export const RECOMPUTE_TAG = Symbol('RECOMPUTE_TAG');
+const RECOMPUTE_TAG = Symbol('RECOMPUTE_TAG');
 
 // Signature type utilities
 type GetOr<T, K, Else> = K extends keyof T ? T[K] : Else;
@@ -293,7 +293,7 @@ class SimpleClassicHelperManager implements HelperManager<() => unknown> {
   }
 }
 
-export const SIMPLE_CLASSIC_HELPER_MANAGER = new SimpleClassicHelperManager();
+const SIMPLE_CLASSIC_HELPER_MANAGER = new SimpleClassicHelperManager();
 
 setHelperManager(() => SIMPLE_CLASSIC_HELPER_MANAGER, Wrapper.prototype);
 
diff --git a/packages/@ember/-internals/glimmer/lib/modifiers/internal.ts b/packages/@ember/-internals/glimmer/lib/modifiers/internal.ts
diff --git a/packages/@ember/-internals/glimmer/lib/renderer.ts b/packages/@ember/-internals/glimmer/lib/renderer.ts
@@ -363,7 +363,7 @@ interface RendererData {
   builder: IBuilder;
 }
 
-export class RendererState {
+class RendererState {
   static create(data: RendererData, renderer: BaseRenderer): RendererState {
     const state = new RendererState(data, renderer);
     associateDestroyableChild(renderer, state);
@@ -717,7 +717,7 @@ export function renderComponent(
 const RENDER_CACHE = new WeakMap<IntoTarget, RenderCacheEntry>();
 const RENDERER_CACHE = new WeakMap<object, BaseRenderer>();
 
-export class BaseRenderer {
+class BaseRenderer {
   static strict(
     owner: object,
     document: SimpleDocument | Document,
diff --git a/packages/@ember/-internals/glimmer/lib/resolver.ts b/packages/@ember/-internals/glimmer/lib/resolver.ts
@@ -87,7 +87,7 @@ function lookupComponentPair(owner: InternalOwner, name: string): Nullable<Looku
   }
 }
 
-export const BUILTIN_KEYWORD_HELPERS: Record<string, object> = {
+const BUILTIN_KEYWORD_HELPERS: Record<string, object> = {
   mut,
   readonly,
   unbound,
@@ -101,7 +101,7 @@ export const BUILTIN_KEYWORD_HELPERS: Record<string, object> = {
   '-in-el-null': inElementNullCheckHelper,
 };
 
-export const BUILTIN_HELPERS: Record<string, object> = {
+const BUILTIN_HELPERS: Record<string, object> = {
   ...BUILTIN_KEYWORD_HELPERS,
   array,
   concat,
diff --git a/packages/@ember/-internals/glimmer/lib/syntax/utils.ts b/packages/@ember/-internals/glimmer/lib/syntax/utils.ts
diff --git a/packages/@ember/-internals/glimmer/lib/templates/empty.ts b/packages/@ember/-internals/glimmer/lib/templates/empty.ts
diff --git a/packages/@ember/-internals/glimmer/lib/utils/bindings.ts b/packages/@ember/-internals/glimmer/lib/utils/bindings.ts
@@ -131,7 +131,7 @@ export function createSimpleClassNameBindingRef(inner: Reference, path?: string)
   });
 }
 
-export function createColonClassNameBindingRef(
+function createColonClassNameBindingRef(
   inner: Reference,
   truthy: string,
   falsy: string | undefined
diff --git a/packages/@ember/-internals/glimmer/lib/utils/debug-render-message.ts b/packages/@ember/-internals/glimmer/lib/utils/debug-render-message.ts
diff --git a/packages/@ember/-internals/metal/lib/alias.ts b/packages/@ember/-internals/metal/lib/alias.ts
@@ -58,7 +58,7 @@ class AliasDecoratorImpl extends Function {
   }
 }
 
-export class AliasedProperty extends ComputedDescriptor {
+class AliasedProperty extends ComputedDescriptor {
   readonly altKey: string;
 
   constructor(altKey: string) {
diff --git a/packages/@ember/-internals/metal/lib/decorator.ts b/packages/@ember/-internals/metal/lib/decorator.ts
@@ -76,7 +76,7 @@ export abstract class ComputedDescriptor {
   abstract set(obj: object, keyName: string, value: any | null | undefined): any | null | undefined;
 }
 
-export let COMPUTED_GETTERS: WeakSet<() => unknown>;
+let COMPUTED_GETTERS: WeakSet<() => unknown>;
 
 if (DEBUG) {
   COMPUTED_GETTERS = new WeakSet();
diff --git a/packages/@ember/-internals/metal/lib/dependent_keys.ts b/packages/@ember/-internals/metal/lib/dependent_keys.ts
diff --git a/packages/@ember/-internals/metal/lib/each_proxy_events.ts b/packages/@ember/-internals/metal/lib/each_proxy_events.ts
@@ -1,4 +1,4 @@
-export const EACH_PROXIES = new WeakMap();
+const EACH_PROXIES = new WeakMap();
 
 export function eachProxyArrayWillChange(
   array: any,
diff --git a/packages/@ember/-internals/metal/lib/observer.ts b/packages/@ember/-internals/metal/lib/observer.ts
@@ -113,7 +113,7 @@ export function activateObserver(target: object, eventName: string, sync = false
 let DEACTIVATE_SUSPENDED = false;
 let SCHEDULED_DEACTIVATE: [object, string, boolean][] = [];
 
-export function deactivateObserver(target: object, eventName: string, sync = false) {
+function deactivateObserver(target: object, eventName: string, sync = false) {
   if (DEACTIVATE_SUSPENDED === true) {
     SCHEDULED_DEACTIVATE.push([target, eventName, sync]);
     return;
@@ -265,7 +265,7 @@ export function setObserverSuspended(target: object, property: string, suspended
   }
 }
 
-export function destroyObservers(target: object) {
+function destroyObservers(target: object) {
   if (SYNC_OBSERVERS.size > 0) SYNC_OBSERVERS.delete(target);
   if (ASYNC_OBSERVERS.size > 0) ASYNC_OBSERVERS.delete(target);
 }
diff --git a/packages/@ember/-internals/views/lib/system/utils.ts b/packages/@ember/-internals/views/lib/system/utils.ts
@@ -120,7 +120,7 @@ export function getChildViews(view: View): View[] {
   return collectChildViews(view, registry);
 }
 
-export function initChildViews(view: View): Set<string> {
+function initChildViews(view: View): Set<string> {
   let childViews: Set<string> = new Set();
   CHILD_VIEW_IDS.set(view, childViews);
   return childViews;
@@ -135,7 +135,7 @@ export function addChildView(parent: View, child: View): void {
   childViews.add(getViewId(child));
 }
 
-export function collectChildViews(view: View, registry: Dict<View>): View[] {
+function collectChildViews(view: View, registry: Dict<View>): View[] {
   let views: View[] = [];
   let childViews = CHILD_VIEW_IDS.get(view);
 
@@ -165,7 +165,7 @@ export function getViewBounds(view: View) {
   @method getViewRange
   @param {Ember.View} view
 */
-export function getViewRange(view: View): Range {
+function getViewRange(view: View): Range {
   let bounds = getViewBounds(view);
 
   let range = document.createRange();
diff --git a/packages/@ember/template-compiler/lib/public-types.ts b/packages/@ember/template-compiler/lib/public-types.ts
diff --git a/packages/@ember/template-compiler/type-tests/template.test.ts b/packages/@ember/template-compiler/type-tests/template.test.ts
@@ -1,4 +1,4 @@
-import { template, type EmberPrecompileOptions } from '@ember/template-compiler';
+import { template } from '@ember/template-compiler';
 import type { TemplateOnlyComponent } from '@ember/component/template-only';
 import { expectTypeOf } from 'expect-type';
 
diff --git a/packages/@glimmer/debug/lib/debug.ts b/packages/@glimmer/debug/lib/debug.ts
@@ -5,20 +5,11 @@ import type {
   Nullable,
   Optional,
   Program,
-  ProgramConstants,
   RuntimeOp,
 } from '@glimmer/interfaces';
-import {
-  CURRIED_COMPONENT,
-  CURRIED_HELPER,
-  CURRIED_MODIFIER,
-  decodeHandle,
-  decodeImmediate,
-} from '@glimmer/constants';
 import { exhausted, expect, unreachable } from '@glimmer/debug-util';
 import { LOCAL_DEBUG, LOCAL_SUBTLE_LOGGING, LOCAL_TRACE_LOGGING } from '@glimmer/local-debug-flags';
 import { enumerate, LOCAL_LOGGER } from '@glimmer/util';
-import { $fp, $pc, $ra, $s0, $s1, $sp, $t0, $t1, $v0 } from '@glimmer/vm';
 
 import type { Primitive, RegisterName } from './dism/dism';
 import type { NormalizedOperand, OperandType, ShorthandOperand } from './dism/operand-types';
diff --git a/packages/@glimmer/destroyable/test/destroyables-test.ts b/packages/@glimmer/destroyable/test/destroyables-test.ts
@@ -1,5 +1,4 @@
 import { DEBUG } from '@glimmer/env';
-import type { GlobalContext } from '@glimmer/global-context';
 import { unwrap } from '@glimmer/debug-util';
 import {
   _hasDestroyableChildren,
diff --git a/packages/@glimmer/program/lib/program.ts b/packages/@glimmer/program/lib/program.ts
@@ -43,7 +43,6 @@ export class ProgramHeapImpl implements ProgramHeap {
   private heap: Int32Array;
   private handleTable: number[];
   private handleState: TableSlotState[];
-  private handle = 0;
 
   constructor() {
     this.heap = new Int32Array(PAGE_SIZE);
diff --git a/packages/@glimmer/reference/test/iterable-test.ts b/packages/@glimmer/reference/test/iterable-test.ts
@@ -1,7 +1,4 @@
-import type { GlobalContext } from '@glimmer/global-context';
 import type { OpaqueIterationItem, Reference } from '@glimmer/reference';
-import { unwrap } from '@glimmer/debug-util';
-import { testOverrideGlobalContext } from '@glimmer/global-context';
 import { createComputeRef, createIteratorRef, valueForRef } from '@glimmer/reference';
 import { consumeTag, VOLATILE_TAG } from '@glimmer/validator';
 
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/smoke-tests/node-template/package.json b/smoke-tests/node-template/package.json

Original file line number	Diff line number	Diff line change
`@@ -531,11 +531,11 @@ export function initialRenderInstrumentDetails(component: any): any {`
`531`	`531`	`return component.instrumentDetails({ initialRender: true });`
`532`	`532`	`}`
`533`	`533`
`534`		`-export function rerenderInstrumentDetails(component: any): any {`
	`534`	`+function rerenderInstrumentDetails(component: any): any {`
`535`	`535`	`return component.instrumentDetails({ initialRender: false });`
`536`	`536`	`}`
`537`	`537`
`538`		`-export const CURLY_CAPABILITIES: InternalComponentCapabilities = {`
	`538`	`+const CURLY_CAPABILITIES: InternalComponentCapabilities = {`
`539`	`539`	`dynamicLayout: true,`
`540`	`540`	`dynamicTag: true,`
`541`	`541`	`prepareArgs: true,`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ import { getInternalHelperManager, helperCapabilities, setHelperManager } from '`
`14`	`14`	`import type { DirtyableTag } from '@glimmer/validator';`
`15`	`15`	`import { consumeTag, createTag, dirtyTag } from '@glimmer/validator';`
`16`	`16`
`17`		`-export const RECOMPUTE_TAG = Symbol('RECOMPUTE_TAG');`
	`17`	`+const RECOMPUTE_TAG = Symbol('RECOMPUTE_TAG');`
`18`	`18`
`19`	`19`	`// Signature type utilities`
`20`	`20`	`type GetOr<T, K, Else> = K extends keyof T ? T[K] : Else;`
`@@ -293,7 +293,7 @@ class SimpleClassicHelperManager implements HelperManager<() => unknown> {`
`293`	`293`	`}`
`294`	`294`	`}`
`295`	`295`
`296`		`-export const SIMPLE_CLASSIC_HELPER_MANAGER = new SimpleClassicHelperManager();`
	`296`	`+const SIMPLE_CLASSIC_HELPER_MANAGER = new SimpleClassicHelperManager();`
`297`	`297`
`298`	`298`	`setHelperManager(() => SIMPLE_CLASSIC_HELPER_MANAGER, Wrapper.prototype);`
`299`	`299`
Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ export function createSimpleClassNameBindingRef(inner: Reference, path?: string)`
`131`	`131`	`});`
`132`	`132`	`}`
`133`	`133`
`134`		`-export function createColonClassNameBindingRef(`
	`134`	`+function createColonClassNameBindingRef(`
`135`	`135`	`inner: Reference,`
`136`	`136`	`truthy: string,`
`137`	`137`	`falsy: string \| undefined`