File tree Expand file tree Collapse file tree
packages/@glimmer/destroyable Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -183,12 +183,6 @@ export function destroy(destroyable: Destroyable) {
183183 } ) ;
184184
185185 meta . state = DESTROYED_STATE ;
186-
187- // Release references so GC can reclaim the destroyed tree
188- meta . parents = null ;
189- meta . children = null ;
190- meta . eagerDestructors = null ;
191- meta . destructors = null ;
192186 } ) ;
193187}
194188
Original file line number Diff line number Diff line change @@ -2,7 +2,6 @@ import { DEBUG } from '@glimmer/env';
22import type { GlobalContext } from '@glimmer/global-context' ;
33import { unwrap } from '@glimmer/debug-util' ;
44import {
5- _hasDestroyableChildren ,
65 assertDestroyablesDestroyed ,
76 associateDestroyableChild ,
87 destroy ,
@@ -385,23 +384,6 @@ module('Destroyables', (hooks) => {
385384 assert . verifySteps ( [ 'child destructor' , 'parent destructor' ] , 'destructors run bottom up' ) ;
386385 } ) ;
387386
388- test ( 'metadata children reference is cleared after destruction completes' , ( assert ) => {
389- const parent = { } ;
390- const child = { } ;
391-
392- associateDestroyableChild ( parent , child ) ;
393-
394- assert . true ( _hasDestroyableChildren ( parent ) , 'parent has children before destruction' ) ;
395-
396- destroy ( parent ) ;
397- flush ( ) ;
398-
399- assert . false (
400- _hasDestroyableChildren ( parent ) ,
401- 'parent metadata clears children reference after destruction, allowing GC to reclaim the tree'
402- ) ;
403- } ) ;
404-
405387 if ( DEBUG ) {
406388 test ( 'attempting to unregister a destructor that was not registered throws an error' , ( assert ) => {
407389 assert . throws ( ( ) => {
You can’t perform that action at this time.
0 commit comments