Skip to content

Commit c857465

Browse files
NullVoxPopuliclaude
andcommitted
Remove template field from debug render tree
The `name` field already identifies components in the render tree (now reliably, thanks to the object-based scope bag). The `template` field (module name of the backing template) adds no useful information beyond what `name` provides, so remove it from `RenderNode`, `CapturedRenderNode`, and all producers/consumers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3cd6494 commit c857465

File tree

10 files changed

+12
-197
lines changed

10 files changed

+12
-197
lines changed

packages/@ember/-internals/glimmer/lib/component-managers/mount.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,7 @@ class MountManager
123123
getDebugCustomRenderTree(
124124
definition: EngineDefinitionState,
125125
state: EngineState,
126-
args: CapturedArguments,
127-
templateModuleName?: string
126+
args: CapturedArguments
128127
): CustomRenderNode[] {
129128
return [
130129
{
@@ -140,7 +139,6 @@ class MountManager
140139
type: 'route-template',
141140
name: 'application',
142141
args,
143-
template: templateModuleName,
144142
},
145143
];
146144
}

packages/@ember/-internals/glimmer/lib/component-managers/outlet.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ class OutletComponentManager
131131
name: 'main',
132132
args: EMPTY_ARGS,
133133
instance: undefined,
134-
template: undefined,
135134
});
136135

137136
if (state.engine) {
@@ -141,7 +140,6 @@ class OutletComponentManager
141140
name: state.engine.mountPoint,
142141
args: EMPTY_ARGS,
143142
instance: state.engine.instance,
144-
template: undefined,
145143
});
146144
}
147145

packages/@ember/-internals/glimmer/lib/component-managers/route-template.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ interface RouteTemplateInstanceState {
2828

2929
export interface RouteTemplateDefinitionState {
3030
name: string;
31-
templateName: string;
3231
}
3332

3433
const CAPABILITIES: InternalComponentCapabilities = {
@@ -79,7 +78,7 @@ class RouteTemplateManager
7978
}
8079

8180
getDebugCustomRenderTree(
82-
{ name, templateName }: RouteTemplateDefinitionState,
81+
{ name }: RouteTemplateDefinitionState,
8382
state: RouteTemplateInstanceState,
8483
args: CapturedArguments
8584
): CustomRenderNode[] {
@@ -90,7 +89,6 @@ class RouteTemplateManager
9089
name,
9190
args,
9291
instance: state.controller,
93-
template: templateName,
9492
},
9593
];
9694
}
@@ -137,7 +135,7 @@ export class RouteTemplate implements ComponentDefinition<
137135
// outlet's name. Also, setting this overrides `getDebugName()` in that
138136
// message. Is that desirable?
139137
this.resolvedName = name;
140-
this.state = { name, templateName: unwrapped.moduleName };
138+
this.state = { name };
141139
this.compilable = unwrapped.asLayout();
142140
}
143141
}

0 commit comments

Comments
 (0)