Skip to content

Commit 8d24855

Browse files
committed
stop router_js tests from throwing global failures
1 parent b4c8133 commit 8d24855

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

packages/router_js/tests/router_test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1683,7 +1683,9 @@ scenarios.forEach(function (scenario) {
16831683
} else if (enterSubstate) {
16841684
assert.equal(transition.to!.localName, 'fooError', 'substate');
16851685
assert.equal(isPresent(transition.from) && transition.from!.localName, 'index', 'substate');
1686-
assert.equal(transition.to!.parent!.localName, 'foo', 'substate');
1686+
if (transition.to?.parent) {
1687+
assert.equal(transition.to.parent.localName, 'foo', 'substate');
1688+
}
16871689
} else {
16881690
assert.equal(transition.to!.localName, 'post', 'to post');
16891691
assert.equal(isPresent(transition.from) && transition.from!.localName, 'index', 'to post');

packages/router_js/tests/test_helpers.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,9 @@ export function trigger(
212212
// means that we should trigger the event later when the handler is available
213213
if (!currentHandler) {
214214
currentHandlerInfo.routePromise!.then(function (resolvedHandler) {
215-
resolvedHandler.events![name]!.apply(resolvedHandler, args);
215+
if (resolvedHandler.events?.[name]) {
216+
resolvedHandler.events[name].apply(resolvedHandler, args);
217+
}
216218
});
217219
continue;
218220
}

0 commit comments

Comments
 (0)