Skip to content

Commit 2363efa

Browse files
authored
Merge pull request #21162 from emberjs/kg-only-replace-test-on-classic
2 parents ed5a91a + a124696 commit 2363efa

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.github/scripts/update-smoke-test-template.mjs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import fs from "node:fs";
33
import path from "node:path";
44

5-
const [appDir, targetDir] = process.argv.slice(2);
5+
const [appDir, targetDir, replaceTestScript = "false"] = process.argv.slice(2);
66

77
if (!appDir || !targetDir) {
88
console.error("Usage: update-smoke-test-template.sh <appDir> <targetDir>");
@@ -25,7 +25,10 @@ fs.rmSync(path.join(resolvedAppDir, ".ember-cli"), { force: true });
2525
const pkgPath = path.join(resolvedAppDir, "package.json");
2626
const pkg = readJson(pkgPath);
2727
pkg.scripts = pkg.scripts || {};
28-
pkg.scripts.test = "ember test";
28+
const shouldReplaceTest = replaceTestScript === "true";
29+
if (shouldReplaceTest) {
30+
pkg.scripts.test = "ember test";
31+
}
2932

3033
if (pkg.devDependencies && pkg.devDependencies["@glimmer/component"]) {
3134
pkg.devDependencies["@glimmer/component"] = "workspace:^";

.github/workflows/smoke-test-app-template-updates.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ jobs:
4545
pnpm dlx ember-cli@latest new ember-test-app -b @ember-tooling/classic-build-app-blueprint --no-welcome --skip-git --skip-npm --ember-data=false
4646
node "$GITHUB_WORKSPACE/.github/scripts/update-smoke-test-template.mjs" \
4747
"$tmpdir/ember-test-app" \
48-
"$GITHUB_WORKSPACE/smoke-tests/app-template"
48+
"$GITHUB_WORKSPACE/smoke-tests/app-template" \
49+
"true"
4950
- name: Install workspace deps
5051
run: pnpm install --no-frozen-lockfile
5152

0 commit comments

Comments
 (0)