Update everything, move away from ember-cli-typescript (#270)

* Remove deprecated `loc`

* v3.9.0...v3.28.0

* Lint & Prettier fix; remove unused generated test

* Update CI with new ember-try scenarios

* Update types and copy ts setup from ember-test-helpers

* Lint fixup

* `yarn test` runs ember:try, make not-explicitly-ember-try tests in CI
only run ember tests

* dont fail fast on matrix tests

Failing fast makes it difficult to diagnose the subset of the matrix
that is failing beyond the first job that fails

* Fix TypeScript compilation

Currently this is clearly suboptimal, once we learn more about TS in our projects. We can revisit ember-cli-typescript (or similar) to handle this for us automatically. Additionally, we plan embroider v2 to enable this “for free”

* Re-roll lock file

* Upgrade some more deps

* Fix gitignore + npmignore files

* updates

Co-authored-by: Stefan Penner <stefan.penner@gmail.com>

Author: kategengler

.editorconfig

@@ -4,7 +4,6 @@
 
 root = true
 
-
 [*]
 end_of_line = lf
 charset = utf-8

.eslintignore

@@ -13,8 +13,12 @@
 # misc
 /coverage/
 !.*
+.*/
+.eslintcache
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
 /package.json.ember-try
+
+

.eslintrc.js

@@ -1,52 +1,55 @@
 module.exports = {
   root: true,
+  parser: '@typescript-eslint/parser',
   parserOptions: {
     ecmaVersion: 2017,
-    sourceType: 'module'
+    sourceType: 'module',
   },
-  plugins: [
-    'ember'
-  ],
+  plugins: ['ember', 'prettier', '@typescript-eslint'],
   extends: [
     'eslint:recommended',
-    'plugin:ember/recommended'
+    'plugin:ember/recommended',
+    'plugin:prettier/recommended',
   ],
   env: {
-    browser: true
-  },
-  rules: {
+    browser: true,
   },
+  rules: {},
   overrides: [
-    // node files
+    {
+      files: ['**/*.ts'],
+      extends: ['plugin:@typescript-eslint/eslint-recommended'],
+      rules: {
+        'no-unused-vars': 'off',
+      },
+    },
     {
       files: [
-        '.eslintrc.js',
-        '.template-lintrc.js',
-        'ember-cli-build.js',
-        'index.js',
-        'testem.js',
-        'blueprints/*/index.js',
-        'config/**/*.js',
-        'tests/dummy/config/**/*.js'
-      ],
-      excludedFiles: [
-        'addon/**',
-        'addon-test-support/**',
-        'app/**',
-        'tests/dummy/app/**'
+        './.eslintrc.js',
+        './.prettierrc.js',
+        './.template-lintrc.js',
+        './ember-cli-build.js',
+        './index.js',
+        './testem.js',
+        './blueprints/*/index.js',
+        './config/**/*.js',
+        './tests/dummy/config/**/*.js',
+        './server/**/*.js',
       ],
       parserOptions: {
         sourceType: 'script',
-        ecmaVersion: 2015
       },
       env: {
         browser: false,
-        node: true
+        node: true,
       },
       plugins: ['node'],
-      rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
-        // add your custom rules and overrides for node files here
-      })
-    }
-  ]
+      extends: ['plugin:node/recommended'],
+    },
+    {
+      // Test files:
+      files: ['tests/**/*-test.{js,ts}'],
+      extends: ['plugin:qunit/recommended'],
+    },
+  ],
 };

.github/workflows/ci-build.yml

@@ -21,7 +21,7 @@ jobs:
           node-version: 12.x
       - run: yarn install --frozen-lockfile
       - run: yarn lint
-      - run: yarn test
+      - run: yarn test:ember
 
   floating-dependencies:
     name: "Floating Dependencies"
@@ -33,7 +33,7 @@ jobs:
         with:
           node-version: 14.x
       - run: yarn install --no-lockfile
-      - run: yarn test
+      - run: yarn test:ember
 
   try-scenarios:
     name: "Try: ${{ matrix.ember-try-scenario }}"
@@ -43,16 +43,17 @@ jobs:
     needs: test
 
     strategy:
-      fail-fast: true
       matrix:
         ember-try-scenario:
-          - ember-lts-3.8
-          - ember-lts-3.12
-          - ember-lts-3.16
           - ember-lts-3.20
+          - ember-lts-3.24
           - ember-release
           - ember-beta
+          - ember-canary
           - ember-default-with-jquery
+          - ember-classic
+          - embroider-safe
+          - embroider-optimized
 
     steps:
       - uses: actions/checkout@v2

.gitignore

@@ -11,6 +11,7 @@
 # misc
 /.env*
 /.sass-cache
+/.eslintcache
 /connect.lock
 /coverage/
 /libpeerconnection.log
@@ -22,3 +23,9 @@
 /.node_modules.ember-try/
 /bower.json.ember-try
 /package.json.ember-try
+
+# typescript related output files
+addon/**/*.js
+addon/**/*.d.ts
+package/
+*.tgz

.npmignore

@@ -10,22 +10,40 @@
 /.editorconfig
 /.ember-cli
 /.env*
+/.eslintcache
 /.eslintignore
 /.eslintrc.js
+/.git/
 /.gitignore
+/.prettierignore
+/.prettierrc.js
 /.template-lintrc.js
 /.travis.yml
 /.watchmanconfig
 /bower.json
-/config/ember-try.js
+/config/
 /CONTRIBUTING.md
 /ember-cli-build.js
 /testem.js
 /tests/
+/yarn-error.log
 /yarn.lock
 .gitkeep
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
 /package.json.ember-try
+
+# typescript
+#
+# avoid publishing .d.ts or .ts files
+# until they have become enforced "public" APIs
+*.ts
+# to enable d.ts consumption remove the next line
+# !*.d.ts
+!addon/**/*.js
+server/
+tsconfig.json
+*.tgz
+DEPRECATIONS.md

.prettierignore

@@ -0,0 +1,21 @@
+# unconventional js
+/blueprints/*/files/
+/vendor/
+
+# compiled output
+/dist/
+/tmp/
+
+# dependencies
+/bower_components/
+/node_modules/
+
+# misc
+/coverage/
+!.*
+.eslintcache
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/package.json.ember-try

.prettierrc.js

@@ -0,0 +1,5 @@
+'use strict';
+
+module.exports = {
+  singleQuote: true,
+};

.template-lintrc.js

@@ -1,5 +1,5 @@
 'use strict';
 
 module.exports = {
-  extends: 'recommended'
+  extends: 'recommended',
 };